Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vite dev mode loads all icon chunks with 3.19.0 (React) #54

Closed
ngocson092 opened this issue Dec 12, 2024 · 1 comment · Fixed by #59
Closed

Vite dev mode loads all icon chunks with 3.19.0 (React) #54

ngocson092 opened this issue Dec 12, 2024 · 1 comment · Fixed by #59

Comments

@ngocson092
Copy link

This repo is very good, but it's slow. I found the cause in tabler-icons and have fixed it following the instructions from this link. Please update it.
tabler/tabler-icons#1233 (comment)
satnaing added a commit that referenced this issue Dec 13, 2024
@satnaing
fix: loading all tabler-icon chunks in dev mode
e8ca252 
Unnecessary tabler icon chunks are loaded in dev
mode which causes the performance issue during development.
This issue is solved by replacing the import alias
for '@tabler/icons-react' in vite.config.ts

Resolves #54
@satnaing satnaing mentioned this issue Dec 13, 2024
Merged
@satnaing
Copy link
Owner

Thank you so much for this. @ngocson092
I overlooked the root cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: loading all tabler-icon chunks in dev mode satnaing/shadcn-admin
2 participants
@ngocson092 @satnaing