Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End stdin on ctrl+d #204

Closed
wants to merge 2 commits into from
Closed

End stdin on ctrl+d #204

wants to merge 2 commits into from

Conversation

vendethiel
Copy link
Contributor

Looks like Windows can't generate EOF, which prevents using coco -s

  • Should it be CTRL+D to be on par with unix ?
  • Should it be CTRL+Z because Wiki said it was the code used back then
  • maybe another way to track that ? this requires a CR currently.
  • do you not want that

@satyr
Copy link
Owner

satyr commented Feb 25, 2013

Should it be CTRL+D ...
Should it be CTRL+Z ...

How about both.

maybe another way to track that ?

No idea.

do you not want that

Doesn't hurt I guess. Lemme whip up a cleaner patch.

@satyr satyr closed this in ace3e15 Feb 25, 2013
@vendethiel
Copy link
Contributor Author

Indeed cleaner, but I wanted 3 + 4<ctrl-D> to work too. (No idea I could've used it.0 haha...).

@satyr
Copy link
Owner

satyr commented Feb 25, 2013

Uh. So 3 + 4<^D> + 5 should read as 3 + 4 as well?

Seems a lil too much to allow those EOF characters terminate anywhere, since they can validly appear in a JS string.

@vendethiel
Copy link
Contributor Author

No - not anywhere.

if it.0 of [4 26] or it[*-1] of [4 26]

While I'm at it, just asking - would you mind a PR for a real website, not just 4/5 coco-related links ? Rather than the additions page.

@vendethiel vendethiel deleted the stdinctrlz branch February 25, 2013 19:48
@satyr
Copy link
Owner

satyr commented Feb 25, 2013

I see, last-position-only makes more sense. Can do that.

Since you have to enter anyway, code.slice(-3) would be '\x04\r\n' right?

would you mind a PR for a real website, not just 4/5 coco-related links ? Rather than the additions page.

PR for index.html? 'course welcome.

@vendethiel
Copy link
Contributor Author

right?

yes

PR for index.html? 'course welcome.

will select a theme and put things in form - got people interested in that too

satyr added a commit that referenced this pull request Feb 25, 2013
vendethiel added a commit to vendethiel/LiveScript that referenced this pull request Jul 19, 2013
gkz added a commit to gkz/LiveScript that referenced this pull request Jul 20, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants