Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove autoInfusing iifes #235

Merged
merged 1 commit into from
Jan 31, 2014
Merged

remove autoInfusing iifes #235

merged 1 commit into from
Jan 31, 2014

Conversation

vendethiel
Copy link
Contributor

No description provided.

@satyr
Copy link
Owner

satyr commented Dec 2, 2013

Context: gkz/LiveScript#423

@@ -110,7 +110,7 @@
carp: ->
throw SyntaxError "#it on line #{ @line or @traverseChildren -> it.line }"

# Defines delegaters.
# Defines delegators.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to find it but couldn't : http://en.wiktionary.org/wiki/delegaters
but found "delegators" :

http://en.wiktionary.org/wiki/delegators
so it seemed like a typo to me

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks.

Try to avoid irrelevant changes in PR though. Every one of those lines prevents swift merging.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I'll try not to do that in the future.

@vendethiel
Copy link
Contributor Author

Also, if you want me to "upport" the generator PR, tell me which syntax you'd like

satyr added a commit that referenced this pull request Jan 31, 2014
removed IIFE auto-infusion
@satyr satyr merged commit b8581d6 into satyr:master Jan 31, 2014
@vendethiel vendethiel deleted the removeAII branch January 31, 2014 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants