fix downloading custom sauce connect version

saucelabs · Jan 29, 2025 · eb38a2b · eb38a2b
1 parent 015c8a8
commit eb38a2b
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 9 deletions.
diff --git a/apis/sauce.json b/apis/sauce.json
@@ -789,7 +789,7 @@
     "clientVersion": {
       "description": "SC client version",
       "in": "query",
-      "name": "client_version",
+      "name": "version",
       "required": false,
       "type": "string"
     },

diff --git a/src/index.js b/src/index.js
@@ -323,8 +323,8 @@ export default class SauceLabs {
     const isDownloaded = await scLoader.verifyAlreadyDownloaded();
 
     if (!isDownloaded) {
+      console.info(`Downloading Sauce Connect v${sauceConnectVersion}...`);
       let download = await this._getSauceConnectDownload(sauceConnectVersion);
-
       // downloaded version may differ from the input version, eg. if a partial version is given as input
       // update scLoader if necessary
       if (download.version != sauceConnectVersion) {
@@ -619,11 +619,7 @@ export default class SauceLabs {
       }
 
       if (typeof optionValue !== 'undefined') {
-        // version is a reserved keyword, so convert to the parameter name here
-        const optionName =
-          optionParam.name == 'client_version' ? 'version' : optionParam.name;
-
-        bodyMap.set(optionName, optionValue);
+        bodyMap.set(optionParam.name, optionValue);
       }
     }
 

diff --git a/tests/index.test.js b/tests/index.test.js
@@ -433,7 +433,7 @@ test('should contain expected macos download link', async () => {
     })
   );
   const scDownload = await api.scDownload({
-    client_version: '5.2.2',
+    version: '5.2.2',
     os: 'macos',
     arch: 'x86_64',
   });
@@ -461,7 +461,7 @@ test('should contain expected windows download link', async () => {
     })
   );
   const scDownload = await api.scDownload({
-    client_version: '5.2.2',
+    version: '5.2.2',
     os: 'windows',
     arch: 'x86_64',
   });