Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix proxy agent error #89

Merged
merged 2 commits into from
Jul 2, 2020
Merged

Fix proxy agent error #89

merged 2 commits into from
Jul 2, 2020

Conversation

enriquegh
Copy link
Contributor

got was upgraded to 11.x:
57aba75

Per their 11.0 release the way agent is instantiated changed. See:
https://github.com/sindresorhus/got/releases/tag/v11.0.0

This PR adds the agent details as an Object.

Fixes #87

Copy link
Contributor

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks 👍

@christian-bromann christian-bromann merged commit d677522 into master Jul 2, 2020
@christian-bromann christian-bromann deleted the eg-got-proxy-fix branch July 2, 2020 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Expected the options.agent properties to be http, https or http2, got options
2 participants