better error handling in http broadcasts ; remove blocking behavior from MoveNextAsync()
#119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in0finite
changed the title
MoveNextAsync()
|
Thanks for raising these issues - rather than adding more retry/throttling logic into this library, I've added an example of how to do this in the HttpClient: https://github.com/saul/demofile-net/pull/122/files. I will most likely move forward with this approach rather than the implementation you did here - I believe you can achieve the same behaviour this way still. |
saul
reviewed
Nov 2, 2024
| @@ -33,50 +33,104 @@ public HttpBroadcastReader(DemoParser<TGameParser> demo, HttpClient httpClient) | |||
| _channel = Channel.CreateUnbounded<QueuedCommand>(); | |||
| } | |||
|
|
|||
| public BroadcastSyncDto? BroadcastSyncDto { get; private set; } | |||
saul
reviewed
Nov 2, 2024
| /// <summary> | ||
| /// The most recently received tick over the HTTP broadcast. | ||
| /// </summary> | ||
| public DemoTick BufferTailTick => new(Volatile.Read(ref _tailTick)); | ||
|
|
||
| public int EnqueuedFragmentsCount => _channel.Reader.Count; |
saul
reviewed
Nov 2, 2024
|
|
||
| // Complete the Channel so that reader can be unblocked. | ||
| // Note that exception is passed to the function, so reader will fail with same exception when trying to wait on empty Channel. | ||
| _channel.Writer.Complete(ex); |
|
That PR still doesn't solve the issue of blocking : |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will prevent blocking in
MoveNextAsync(), by callingWriter.Complete()when exception happens, and will throw appropriate exception (the one from worker) when Channel becomes empty.So instead of blocking application for 10-15 seconds (like you suggested in other issue) when http broadcast has ended, you get the right exception immediately.
This PR also stops worker from entering infinite loop, when server starts returning 404 error for finished match.
Edit: removed blocking behavior from
MoveNextAsync(), and added another methodWaitForAvailableDataAsync()with same functionality