Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi-threaded parsing #51

Closed
wants to merge 3 commits into from

Conversation

in0finite
Copy link
Contributor

@in0finite in0finite commented Mar 1, 2024

Benchmark (6 cores):

Method Job Arguments Mean Error StdDev Ratio RatioSD Gen0 Gen1 Gen2 Allocated Alloc Ratio
ParseDemo Job-PEXGNK /p:Baseline=true 1,486.5 ms 6.50 ms 6.08 ms 1.00 0.00 26000.0000 1000.0000 - 489.9 MB 1.00
ParseDemo Job-MQEQFA Default 1,485.7 ms 6.48 ms 6.06 ms 1.00 0.00 26000.0000 1000.0000 - 489.9 MB 1.00
ParseDemoMT Job-PEXGNK /p:Baseline=true NA NA NA ? ? NA NA NA NA ?
ParseDemoMT Job-MQEQFA Default 447.2 ms 23.40 ms 21.89 ms ? ? 34000.0000 11000.0000 1000.0000 582.88 MB ?

@saul
Copy link
Owner

saul commented Mar 17, 2024

Many thanks for this! I've built on this as part of #52 - simplifying the API and integrating all of the integration tests.

It's still WIP as there are a couple of bugs that need resolving, but this is a great improvement to performance. Thanks again

@in0finite
Copy link
Contributor Author

Alright.

Btw, it seems that your implementation is slightly slower (540 ms compared to 450 ms), even if Mac has higher CPU count. Will test it when you merge, to verify.

@saul saul closed this in #52 Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants