Support changing cipher and set AES-GCM as default cipher #383

tmpfs · 2024-04-10T02:19:17Z

Local account updates files on disc and in-memory summaries
Network account force pushes updated account data to remote servers
Network account clients handle diverged trees and pull fresh account data
Store update identity event in the account event log

Closes #381

Requires work to write out the new identity vault and events. Includes an improvement to the API for VaultBuilder.

To accommodate the need to completely overwrite the account data for destructive operations such as changing encryption cipher. create_account -> PUT (formerly POST) sync_account -> PATCH (formerly PUT) And added a stub handler which will overwrite all account data with the given ChangeSet: update_account -> POST We now need to re-deploy the demo and test self-hosted services after this commit is merged.

To be distinct from the ChangeSet type used to create a new account on a remote server as when forcefully updating we only need the folders to be entire event logs. Any changes to the account, device and files event logs can be patched from diffs.

So that a network account can force an update of an account's folders after making destructive changes.

So that we can handle the case when a comparison is unknown which will require further communication with the remote to determine if the trees have completely diverged.

So that the client can test whether event logs have completely diverged.

To overwrite the data for an identity folder; requires work to log and process an AccountEvent::UpdateIdentity variant which will be detected on merge of account data to sync identity data after destructive changes (cipher change or account password change).

tmpfs · 2024-04-13T08:05:51Z

Just saw this error on a test run:

Error: invalid nonce
test change_cipher::network_sync_change_cipher ... FAILED

failures:

failures:
    change_cipher::network_sync_change_cipher

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 26 filtered out; f

Edit: this problem occurs when converting the identity folder before the user folders, fixed by changing the order back. Not sure why this would happen.

The reason this happens is that updating the cipher for a user folder requires looking up the folder password in the identity folder. If we update the cipher on the identity folder first then the identity folder has been invalidated but we don't sign in again until after all changes have completed (identity folder and user folders).

So that the change_cipher test spec now passes.

tmpfs added 4 commits April 9, 2024 10:45

Default cipher is AES-GCM.

b7afda3

Sketch CLI command and conversion structs.

631573d

Define change_cipher() on Account trait.

3888f81

Prepare stub test spec for changing cipher.

cbc4272

tmpfs self-assigned this Apr 10, 2024

tmpfs added 16 commits April 10, 2024 12:19

Draft logic to change cipher for folders.

c66cde4

Requires work to write out the new identity vault and events. Includes an improvement to the API for VaultBuilder.

Write identity vault and events in change_cipher().

cc86ee1

Use NOT_FOUND instead of CONFLICT in update_account.

39ff45e

Prepare stub functions to update account.

bb5937b

Prepare update_account() storage implementation.

cc60de4

Use UpdateSet type.

b006578

To be distinct from the ChangeSet type used to create a new account on a remote server as when forcefully updating we only need the folders to be entire event logs. Any changes to the account, device and files event logs can be patched from diffs.

Prepare HTTP client update_account() function.

6cbfb08

Prepare force_update() method in RemoteSync trait.

4d6c4e2

So that a network account can force an update of an account's folders after making destructive changes.

Call force_update() in change_cipher().

4834e8d

Prepare SyncDiff with MaybeDiff type.

c89b425

So that we can handle the case when a comparison is unknown which will require further communication with the remote to determine if the trees have completely diverged.

Create MaybeDiff::Compare variants.

6ede1b2

Return comparisons in SyncPacket.

9d8fd9a

So that the client can test whether event logs have completely diverged.

Sketch logic to detect diverged trees.

2a46ad5

Add AccountEvent::UpdateIdentity.

4e7a8b1

tmpfs added 3 commits April 13, 2024 16:30

Fix handling of the update identity event.

4d776eb

So that the change_cipher test spec now passes.

Tidy cipher conversion implementation.

c3dca50

Implement convert cipher command.

dbed27d

tmpfs merged commit 0e33b17 into main Apr 14, 2024
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support changing cipher and set AES-GCM as default cipher #383

Support changing cipher and set AES-GCM as default cipher #383

tmpfs commented Apr 10, 2024 •

edited

Loading

tmpfs commented Apr 13, 2024 •

edited

Loading

Support changing cipher and set AES-GCM as default cipher #383

Support changing cipher and set AES-GCM as default cipher #383

Conversation

tmpfs commented Apr 10, 2024 • edited Loading

tmpfs commented Apr 13, 2024 • edited Loading

tmpfs commented Apr 10, 2024 •

edited

Loading

tmpfs commented Apr 13, 2024 •

edited

Loading