Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Incorrect break of newlines in primary constructor #1115

Closed
orchestr7 opened this issue Nov 10, 2021 · 1 comment · Fixed by #1119
Closed

Fix: Incorrect break of newlines in primary constructor #1115

orchestr7 opened this issue Nov 10, 2021 · 1 comment · Fixed by #1119
Assignees
@petertrr
Labels
bug Something isn't working
Milestone
1.0.0

Comments

@orchestr7
Copy link
Member

orchestr7 commented Nov 10, 2021 •
edited by petertrr
Loading 

// Reflekt/SmartReflekt content types
enum class ReflektEntity(
    val entityType: String,     // objects/classes/functions
        val smartClassName: String,  // SmartReflekt nested class - [Object/Class/Function]CompileTimeExpression
)

=>

/**
 * @property entityType
 * @property smartClassName objects/classes/functions
 */
// Reflekt/SmartReflekt content types
enum class ReflektEntity(
    val entityType: String, val smartClassName: String,  // SmartReflekt nested class - [Object/Class/Function]CompileTimeExpression
)
@orchestr7 orchestr7 added the bug Something isn't working label Nov 10, 2021
@petertrr
Copy link
Member

Yep, we are incorrectly moving a comment ( // objects/classes/functions), so that newline disappears

@petertrr petertrr mentioned this issue Nov 12, 2021
Merged
@petertrr petertrr added this to the 1.0.0 milestone Nov 12, 2021
petertrr added a commit that referenced this issue Nov 15, 2021
@petertrr
Fix: Don't remove newline when moving comments into class KDoc (#1119)
e302afa 
### What's done:
* Refactoring in `KdocComments`
* Fix in logic: don't remove `WHITE_SPACE` nodes when moving comment node
* Added tests
* Fixed bug with incorrect `isFixMode` flag in `KdocComments`

This pull request closes #1115
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petertrr petertrr

Labels
bug Something isn't working
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Fix: Don't remove newline when moving comments into class KDoc saveourtool/diktat
2 participants
@petertrr @orchestr7