Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileStructureRule follow-ups #267

Closed
petertrr opened this issue Sep 10, 2020 · 0 comments · Fixed by #636
Closed

FileStructureRule follow-ups #267

petertrr opened this issue Sep 10, 2020 · 0 comments · Fixed by #636
Assignees
@petertrr
Labels
bug Something isn't working

Comments

@petertrr
Copy link
Member

petertrr commented Sep 10, 2020 •
edited
Loading

There are some issues stated in comments in code.

  • handle other elements that could be present before package (other comments)
  • handle cases when PACKAGE_DIRECTIVE node is not present already supports nullable package directive for default package
  • find cases when node.psi.importLists.size > 1 - shouldn't happen in valid kotlin code, handle cases when it's not present at all
@petertrr petertrr added the bug Something isn't working label Sep 10, 2020
@petertrr petertrr self-assigned this Sep 10, 2020
petertrr added a commit that referenced this issue Oct 30, 2020
@petertrr
Issue #267
95c410b 
### What's done:
* Handle cases when package and/or imports are missing in FileStructureRule
petertrr added a commit that referenced this issue Oct 30, 2020
@petertrr
Issue #267
c6b8f27 
### What's done:
* Code style
orchestr7 pushed a commit that referenced this issue Oct 31, 2020
@petertrr
Fixing DiktatRuleSet crashes when there are no package and no imports (…
b08f9d8 
…#464)

Fixing DiktatRuleSet crashes when there are no package and no imports. Issue #267

### What's done:
* Fixed logic in rules
* Added tests
* Added way to disable several rules in smoke test
* Handle cases when package and/or imports are missing in FileStructureRule
* Code style
@petertrr petertrr mentioned this issue Dec 11, 2020
Merged
petertrr added a commit that referenced this issue Dec 11, 2020
@petertrr
#267
af39490 
### What's done:
* Review notes
petertrr added a commit that referenced this issue Dec 11, 2020
@petertrr
#267
520f1c8 
### What's done:
* Review notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petertrr petertrr

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes for FileStructureRule saveourtool/diktat
1 participant
@petertrr