Generic Function Removes Return Type T #1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cheshiriks
force-pushed
the
bugfix/dont_remove_return_type
branch
from
21d073b to
9b1da63
Compare
petertrr
requested changes
Jul 30, 2021
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter3/files/NewlinesRule.kt
Show resolved
Hide resolved
### What's done: * fixed bug in WRONG_NEWLINES * now don't remove return type Closes #965
Cheshiriks
force-pushed
the
bugfix/dont_remove_return_type
branch
from
9b1da63 to
af42cfb
Compare
Codecov Report
@@ Coverage Diff @@
## master #1017 +/- ##
============================================
- Coverage 83.82% 83.77% -0.05%
Complexity 2419 2419
============================================
Files 102 102
Lines 6107 6107
Branches 1809 1808 -1
============================================
- Hits 5119 5116 -3
- Misses 268 273 +5
+ Partials 720 718 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
petertrr
requested changes
Aug 2, 2021
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter3/files/NewlinesRule.kt
Show resolved
Hide resolved
petertrr
approved these changes
Aug 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
Closes Generic Function Removes Return Type T #1000