Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix in TRAILLING_COMMA rule: insert comma in a proper place when there are exists comments #1110

Merged
merged 8 commits into from
Nov 10, 2021

Conversation

kgevorkyan
Copy link
Member

@kgevorkyan kgevorkyan commented Nov 9, 2021

What's done:

  • Bugfix in TRAILLING_COMMA: insert comma in a proper place when there are exists comments
  • Expand tests

### What's done:
* WIP
### What's done:
* WIP
### What's done:
* Typos
@kgevorkyan kgevorkyan changed the title Bugfix in TRAILLING_COMMA rule: insert comma in a proper place when there is exists comments Bugfix in TRAILLING_COMMA rule: insert comma in a proper place when there are exists comments Nov 9, 2021
@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #1110 (a5a74df) into master (b188eab) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1110      +/-   ##
============================================
+ Coverage     83.43%   83.44%   +0.01%     
  Complexity     2462     2462              
============================================
  Files           102      102              
  Lines          6146     6150       +4     
  Branches       1840     1842       +2     
============================================
+ Hits           5128     5132       +4     
  Misses          274      274              
  Partials        744      744              
Flag Coverage Δ
unittests 83.44% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...diktat/ruleset/rules/chapter3/TrailingCommaRule.kt 93.87% <100.00%> (+0.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b188eab...a5a74df. Read the comment docs.

@kgevorkyan kgevorkyan marked this pull request as ready for review November 9, 2021 14:09
### What's done:
* Review
@kgevorkyan kgevorkyan enabled auto-merge (squash) November 9, 2021 14:54
@kgevorkyan kgevorkyan merged commit 0f1f8af into master Nov 10, 2021
@kgevorkyan kgevorkyan deleted the bugfix/trailingcomma branch November 10, 2021 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TRAILLING_COMMA: endless number of trailing commas added with -F (fix mode)
2 participants