-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix in TRAILLING_COMMA rule: insert comma in a proper place when there are exists comments #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgevorkyan
changed the title
Bugfix in TRAILLING_COMMA rule: insert comma in a proper place when there is exists comments
Bugfix in TRAILLING_COMMA rule: insert comma in a proper place when there are exists comments
Nov 9, 2021
Codecov Report
@@ Coverage Diff @@
## master #1110 +/- ##
============================================
+ Coverage 83.43% 83.44% +0.01%
Complexity 2462 2462
============================================
Files 102 102
Lines 6146 6150 +4
Branches 1840 1842 +2
============================================
+ Hits 5128 5132 +4
Misses 274 274
Partials 744 744
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
petertrr
reviewed
Nov 9, 2021
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter3/TrailingCommaRule.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter3/TrailingCommaRule.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/test/resources/test/paragraph3/trailing_comma/TrailingCommaExpected.kt
Show resolved
Hide resolved
…sis/diKTat into bugfix/trailingcomma
petertrr
reviewed
Nov 9, 2021
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter3/TrailingCommaRule.kt
Show resolved
Hide resolved
petertrr
approved these changes
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done: