gradle-plugin: fix behavior in githubActions mode #1229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * Correctly set system property * Rename report; store reports in build directory
Codecov Report
@@ Coverage Diff @@
## master #1229 +/- ##
============================================
+ Coverage 83.87% 83.93% +0.06%
- Complexity 2543 2546 +3
============================================
Files 104 104
Lines 7161 7164 +3
Branches 1939 1939
============================================
+ Hits 6006 6013 +7
+ Misses 352 350 -2
+ Partials 803 801 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
### What's done: * Rename report; store reports in build directory
orchestr7
reviewed
Mar 17, 2022
| @@ -186,7 +191,7 @@ open class DiktatJavaExecTaskBase @Inject constructor( | |||
| // githubActions should have higher priority than a custom input | |||
| if (diktatExtension.githubActions) { | |||
| // need to set user.home specially for ktlint, so it will be able to put a relative path URI in SARIF | |||
| System.setProperty("user.home", project.projectDir.toString()) | |||
| systemProperty("user.home", project.projectDir.toString()) | |||
There was a problem hiding this comment.
in maven plugin this works fine?
There was a problem hiding this comment.
Yes, this change doesn't affect maven plugin
orchestr7
approved these changes
Mar 17, 2022
### What's done: * Tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
This pull request closes #1213