Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Checking white space before opening brace that starts a line #1354

Merged
merged 3 commits into from
Jun 30, 2022

Conversation

petertrr
Copy link
Member

@petertrr petertrr commented Jun 9, 2022

What's done:

  • Fixed logic
  • Added test

This pull request closes #1313

@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #1354 (382c679) into master (43e6098) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1354      +/-   ##
============================================
+ Coverage     83.37%   83.39%   +0.01%     
- Complexity     2557     2561       +4     
============================================
  Files           107      107              
  Lines          7599     7601       +2     
  Branches       2095     2097       +2     
============================================
+ Hits           6336     6339       +3     
  Misses          374      374              
+ Partials        889      888       -1     
Flag Coverage Δ
unittests 83.39% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tat/ruleset/rules/chapter3/files/WhiteSpaceRule.kt 81.81% <100.00%> (+0.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43e6098...382c679. Read the comment docs.

@petertrr petertrr marked this pull request as ready for review June 27, 2022 07:31
@github-actions
Copy link
Contributor

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v1)

1 263 tests   1 248 ✔️  9m 30s ⏱️
   151 suites       15 💤
   151 files           0

Results for commit be955f9.

@github-actions
Copy link
Contributor

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v1)

   151 files     151 suites   10m 58s ⏱️
1 263 tests 1 245 ✔️ 15 💤 3
1 266 runs  1 248 ✔️ 15 💤 3

For more details on these failures, see this check.

Results for commit be955f9.

@orchestr7 orchestr7 added the js label Jun 30, 2022
@petertrr petertrr enabled auto-merge (squash) June 30, 2022 11:40
@petertrr petertrr merged commit cfd9eab into master Jun 30, 2022
@petertrr petertrr deleted the bugfix/issue-1313 branch June 30, 2022 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

false positive finding for WRONG_WHITESPACE on gradle plugins block
2 participants