Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of Kotlin 2.1 and corresponding Ktlint 1.5 update #1947

Merged
merged 4 commits into from
Dec 7, 2024

Conversation

orchestr7
Copy link
Member

@orchestr7 orchestr7 commented Dec 7, 2024

What's done:

Co-authored-by: akuleshov7 [email protected]
Co-authored-by: orchestr7 [email protected]

### What's done:
- Occasionally Kotlin decided to remove several AST Nodes JetBrains/kotlin@76592dc

- There also was such kind of bug caused by Kotlin2 in ktlint pinterest/ktlint#2857

- Also removed Werror flag due to one deprecation warning which we are not able to fix

- Updated tests and Kotlin version to 2.1 in resources

- Fixed some detekt deprecation warnings

- Replaced gradle configuration with new compilerOptions API
Copy link

codecov bot commented Dec 7, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.95%. Comparing base (565f00e) to head (66667bc).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ourtool/diktat/ktlint/DiktatBaselineFactoryImpl.kt 0.00% 1 Missing ⚠️
...urtool/diktat/ktlint/DiktatProcessorFactoryImpl.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1947      +/-   ##
============================================
- Coverage     78.14%   77.95%   -0.20%     
- Complexity     2492     2996     +504     
============================================
  Files           134      134              
  Lines          8778     8863      +85     
  Branches       2240     2119     -121     
============================================
+ Hits           6860     6909      +49     
- Misses          913      943      +30     
- Partials       1005     1011       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Dec 7, 2024

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

  167 files  ±0    167 suites  ±0   3m 17s ⏱️ -33s
1 446 tests ±0  1 407 ✅ ±0  39 💤 ±0  0 ❌ ±0 
2 826 runs  ±0  2 787 ✅ ±0  39 💤 ±0  0 ❌ ±0 

Results for commit 66667bc. ± Comparison against base commit 565f00e.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Dec 7, 2024

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

  167 files  ±0    167 suites  ±0   8m 11s ⏱️ +43s
1 446 tests ±0  1 429 ✅ ±0  17 💤 ±0  0 ❌ ±0 
2 826 runs  ±0  2 809 ✅ ±0  17 💤 ±0  0 ❌ ±0 

Results for commit 66667bc. ± Comparison against base commit 565f00e.

♻️ This comment has been updated with latest results.

@orchestr7
Copy link
Member Author

With sarif4k 0.5.0 we have a failure of diktat 2.0.0 on release version.
With sarif4k 0.6.0 we have a failure on snapshot.

I am choosing snapshot and making a release

@orchestr7 orchestr7 merged commit cd77a0b into master Dec 7, 2024
19 of 21 checks passed
@orchestr7 orchestr7 deleted the feature/kotlin-2-1 branch December 7, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants