-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support of Kotlin 2.1 and corresponding Ktlint 1.5 update #1947
Conversation
### What's done: - Occasionally Kotlin decided to remove several AST Nodes JetBrains/kotlin@76592dc - There also was such kind of bug caused by Kotlin2 in ktlint pinterest/ktlint#2857 - Also removed Werror flag due to one deprecation warning which we are not able to fix - Updated tests and Kotlin version to 2.1 in resources - Fixed some detekt deprecation warnings - Replaced gradle configuration with new compilerOptions API
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1947 +/- ##
============================================
- Coverage 78.14% 77.95% -0.20%
- Complexity 2492 2996 +504
============================================
Files 134 134
Lines 8778 8863 +85
Branches 2240 2119 -121
============================================
+ Hits 6860 6909 +49
- Misses 913 943 +30
- Partials 1005 1011 +6 ☔ View full report in Codecov by Sentry. |
JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2) 167 files ±0 167 suites ±0 3m 17s ⏱️ -33s Results for commit 66667bc. ± Comparison against base commit 565f00e. ♻️ This comment has been updated with latest results. |
JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2) 167 files ±0 167 suites ±0 8m 11s ⏱️ +43s Results for commit 66667bc. ± Comparison against base commit 565f00e. ♻️ This comment has been updated with latest results. |
With sarif4k 0.5.0 we have a failure of diktat 2.0.0 on release version. I am choosing snapshot and making a release |
What's done:
Occasionally Kotlin decided to remove several AST Nodes JetBrains/kotlin@76592dc
There also was such kind of bug caused by Kotlin2 in ktlint Catch java.lang.NoSuchFieldError when looking for WHEN_ENTRY_GUARD in kotlin version 2.0.1 pinterest/ktlint#2857
Removed -Werror flag due to one deprecation warning which we are not able to fix
Updated tests and Kotlin version to 2.1 in resources
Fixed some detekt deprecation warnings
Replaced gradle configuration with new compilerOptions API
Removed unused methods which caused warnings
Updated sarif4k: it caused an error with missing 'void io.github.detekt.sarif4k.ToolComponent.
Co-authored-by: akuleshov7 [email protected]
Co-authored-by: orchestr7 [email protected]