Recommendation 4.3.2 generic types explicit declaration #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * Added rule logic * Added warn tests
### What's done: * Added fix test * Remade logic of rule
…-explicit-declaration
### What's done: * Fixed bugs
Codecov Report
@@ Coverage Diff @@
## master #314 +/- ##
============================================
- Coverage 81.78% 81.76% -0.02%
- Complexity 1075 1093 +18
============================================
Files 53 54 +1
Lines 2767 2786 +19
Branches 876 884 +8
============================================
+ Hits 2263 2278 +15
Misses 183 183
- Partials 321 325 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…-explicit-declaration
…-explicit-declaration
kentr0w
requested changes
Sep 23, 2020
...at-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/VariableGenericTypeDeclarationRule.kt
Outdated
Show resolved
Hide resolved
...at-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/VariableGenericTypeDeclarationRule.kt
Outdated
Show resolved
Hide resolved
...at-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/VariableGenericTypeDeclarationRule.kt
Show resolved
Hide resolved
petertrr
reviewed
Sep 24, 2020
...at-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/VariableGenericTypeDeclarationRule.kt
Show resolved
Hide resolved
petertrr
requested changes
Sep 24, 2020
...at-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/VariableGenericTypeDeclarationRule.kt
Outdated
Show resolved
Hide resolved
### What's done: * Fixed bugs
### What's done: * Fixed bugs * Added fixme
…-explicit-declaration # Conflicts: # diktat-analysis.yml # diktat-rules/src/main/kotlin/generated/WarningNames.kt # diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/constants/Warnings.kt # diktat-rules/src/main/resources/diktat-analysis-huawei.yml # diktat-rules/src/main/resources/diktat-analysis.yml # info/available-rules.md
### What's done: * Fixed bugs
### What's done: * Fixed bugs
petertrr
requested changes
Sep 25, 2020
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/constants/Warnings.kt
Outdated
Show resolved
Hide resolved
...at-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/VariableGenericTypeDeclarationRule.kt
Outdated
Show resolved
Hide resolved
...c/test/kotlin/org/cqfn/diktat/ruleset/chapter4/VariableGenericTypeDeclarationRuleWarnTest.kt
Show resolved
Hide resolved
…-explicit-declaration
### What's done: * Fixed bugs
### What's done: * Fixed bugs
…-explicit-declaration
petertrr
requested changes
Sep 28, 2020
There was a problem hiding this comment.
[INFO] [ktlint] /home/runner/work/diKTat/diKTat/diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/VariableGenericTypeDeclarationRule.kt:60:9: [GENERIC_VARIABLE_WRONG_DECLARATION] variable should have explicit type declaration: val sideRegex = Regex("<([a-zA-Z, <>?]*)>") (cannot be auto-corrected)
something went wrong here...
...at-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/VariableGenericTypeDeclarationRule.kt
Outdated
Show resolved
Hide resolved
### What's done: * Fixed bugs
### What's done: * Fixed bugs
…-explicit-declaration
### What's done: * Fixed bugs
…eric-types-explicit-declaration' into feature/recommendation-4.3.2-generic-types-explicit-declaration
petertrr
reviewed
Sep 29, 2020
| val callExpr = node.findChildByType(CALL_EXPRESSION) | ||
| ?: node.findChildByType(DOT_QUALIFIED_EXPRESSION)?.getAllChildrenWithType(CALL_EXPRESSION)?.lastOrNull() | ||
|
|
||
| val rightSide = sideRegex.find(callExpr?.text ?: "") |
There was a problem hiding this comment.
Maybe it will be more reliable to use something like (callExpr.psi as KtCallExpression).typeArgumentList? To explicitly retrieve type parameters and compare them instead of text.
…laration' of https://github.com/cqfn/diKTat into feature/recommendation-4.3.2-generic-types-explicit-declaration
### What's done: * Logic remade
aktsay6
deleted the
feature/recommendation-4.3.2-generic-types-explicit-declaration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which rule and warnings did you add?
Recommendation 4.3.2 was added: Variables of generic types should have explicit type declaration. Closes #295
Actions checklist