Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing smoke test #342

Merged
merged 7 commits into from
Sep 30, 2020
Merged

Fixing smoke test #342

merged 7 commits into from
Sep 30, 2020

Conversation

orchestr7
Copy link
Member

What's done:

  1. Fixing smoke test
  2. Changes to diktat config to close KotlinParseException in PACKAGE_NAMING in smoke tests #313

### What's done:
1) Fixing smoke test
2) Changes to diktat config to close #313
Copy link
Member

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes look good, but some tests are failing

### What's done:
1) compilation issues fix
### What's done:
1) compilation issues fix
### What's done:
1) compilation issues fix
@codecov
Copy link

codecov bot commented Sep 30, 2020

Codecov Report

Merging #342 into master will increase coverage by 1.10%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #342      +/-   ##
============================================
+ Coverage     81.77%   82.88%   +1.10%     
- Complexity     1102     1125      +23     
============================================
  Files            54       54              
  Lines          2798     2798              
  Branches        890      890              
============================================
+ Hits           2288     2319      +31     
+ Misses          183      162      -21     
+ Partials        327      317      -10     
Flag Coverage Δ Complexity Δ
#unittests 82.88% <ø> (+1.10%) 1125.00 <ø> (+23.00)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...ktat/ruleset/rules/ClassLikeStructuresOrderRule.kt 83.33% <0.00%> (+1.28%) 40.00% <0.00%> (+1.00%)
...n/org/cqfn/diktat/ruleset/utils/StringCaseUtils.kt 82.08% <0.00%> (+1.49%) 0.00% <0.00%> (ø%)
...in/org/cqfn/diktat/ruleset/rules/WhiteSpaceRule.kt 83.33% <0.00%> (+1.51%) 121.00% <0.00%> (+2.00%)
.../org/cqfn/diktat/ruleset/rules/IdentifierNaming.kt 83.18% <0.00%> (+1.76%) 72.00% <0.00%> (+1.00%)
...fn/diktat/ruleset/rules/files/FileStructureRule.kt 57.14% <0.00%> (+1.78%) 19.00% <0.00%> (+1.00%)
...cqfn/diktat/ruleset/rules/comments/CommentsRule.kt 100.00% <0.00%> (+2.04%) 19.00% <0.00%> (+1.00%)
.../diktat/ruleset/rules/MultipleModifiersSequence.kt 97.43% <0.00%> (+2.56%) 14.00% <0.00%> (+3.00%)
...set/rules/calculations/AccurateCalculationsRule.kt 83.33% <0.00%> (+2.77%) 18.00% <0.00%> (+2.00%)
...org/cqfn/diktat/ruleset/rules/kdoc/KdocComments.kt 95.83% <0.00%> (+4.16%) 16.00% <0.00%> (+1.00%)
...in/org/cqfn/diktat/ruleset/rules/EnumsSeparated.kt 97.14% <0.00%> (+5.71%) 18.00% <0.00%> (+2.00%)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0270855...9eeba16. Read the comment docs.

@orchestr7 orchestr7 merged commit ff91017 into master Sep 30, 2020
@petertrr petertrr deleted the feature/smoke-test branch September 30, 2020 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KotlinParseException in PACKAGE_NAMING in smoke tests
2 participants