-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix in IndentationRule (#343) #350
Conversation
### What's done: * Minor fixes
### What's done: * Changed logic * Added tests
### What's done: * Added extendedIndentBeforeDot * Added handling of increasing tokens on the same line
### What's done: * Fixing logic of conditionals and loops without braces * Tests * Code style
### What's done: * Code style
Codecov Report
@@ Coverage Diff @@
## master #350 +/- ##
============================================
+ Coverage 82.80% 82.91% +0.10%
- Complexity 1219 1224 +5
============================================
Files 60 60
Lines 3001 3026 +25
Branches 954 967 +13
============================================
+ Hits 2485 2509 +24
+ Misses 171 170 -1
- Partials 345 347 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
### What's done: * Fixes
### What's done: * Fixes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
### What's done: * Fixes
This pull request closes #343
What's done:
extendedIndentBeforeDot
option in configurationCreated #349 for other discovered issues
FIXME:
extendedIndentBeforeDot
to README3
from new testif
has braces andelse
doesn't