Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/suppress-bug(#372) #375

Merged
merged 2 commits into from
Oct 7, 2020
Merged

bugfix/suppress-bug(#372) #375

merged 2 commits into from
Oct 7, 2020

Conversation

aktsay6
Copy link
Collaborator

@aktsay6 aktsay6 commented Oct 6, 2020

What's done:

  • Fixed bug in calling multiple suppress

This pull request closes #372

Actions checklist

  • Implemented Rule, added Warnings
  • Added tests on checks
  • Added tests on fixers
  • Updated diktat-analysis.yml
  • Updated available-rules.md

### What's done:
  * Fixed bug
@aktsay6 aktsay6 added the bug Something isn't working label Oct 6, 2020
@aktsay6 aktsay6 requested review from petertrr and kentr0w October 6, 2020 19:02
@codecov
Copy link

codecov bot commented Oct 6, 2020

Codecov Report

Merging #375 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #375   +/-   ##
=========================================
  Coverage     82.91%   82.92%           
  Complexity     1224     1224           
=========================================
  Files            60       60           
  Lines          3026     3027    +1     
  Branches        967      968    +1     
=========================================
+ Hits           2509     2510    +1     
  Misses          170      170           
  Partials        347      347           
Flag Coverage Δ Complexity Δ
#unittests 82.92% <100.00%> (+<0.01%) 1224.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...tlin/org/cqfn/diktat/ruleset/utils/AstNodeUtils.kt 82.91% <100.00%> (+0.08%) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77de16f...d3bc382. Read the comment docs.

Copy link
Member

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aktsay6 aktsay6 merged commit bbbe011 into master Oct 7, 2020
@aktsay6 aktsay6 deleted the bugfix/suppress-bug(#372) branch October 7, 2020 10:16
@orchestr7
Copy link
Member

@aktsay6 looks like you are forgetting to squash commits. PLease be careful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suppress doesn't support multiple rules
3 participants