-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENUM_VALUE styles support: snakeCase/pascalCase #408
Conversation
Codecov Report
@@ Coverage Diff @@
## master #408 +/- ##
============================================
+ Coverage 82.59% 82.62% +0.02%
- Complexity 1340 1343 +3
============================================
Files 65 65
Lines 3281 3298 +17
Branches 1049 1055 +6
============================================
+ Hits 2710 2725 +15
Misses 177 177
- Partials 394 396 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Awesome, thanks!!! <3 |
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/IdentifierNaming.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Well, I came to Android development from iOS, and UPPER_SNAKE_CASE for me looks crazy 😁 |
Which rule and warnings did you add?
I've added config value for ENUM_VALUE.
Not everyone prefer snake case: https://discuss.kotlinlang.org/t/enum-constants-uppercase-or-camecase/13984
So there should be a possibility to choose what you prefer
Actions checklist
Fixme
Not sure how can I use different warning for each case