Rule 6.1.6 abstract classes should have at least one abstract method #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * Rule logic made * Added fix and warn tests
Codecov Report
@@ Coverage Diff @@
## master #457 +/- ##
============================================
- Coverage 81.95% 81.94% -0.01%
- Complexity 1435 1445 +10
============================================
Files 69 70 +1
Lines 3591 3617 +26
Branches 1147 1155 +8
============================================
+ Hits 2943 2964 +21
- Misses 201 202 +1
- Partials 447 451 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
### What's done: * Fixed bugs
petertrr
requested changes
Oct 26, 2020
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/constants/Warnings.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/classes/AbstractClassesRule.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/classes/AbstractClassesRule.kt
Outdated
Show resolved
Hide resolved
### What's done: * Fixed bugs
petertrr
requested changes
Oct 26, 2020
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/classes/AbstractClassesRule.kt
Outdated
Show resolved
Hide resolved
### What's done: * Fixed bugs
petertrr
reviewed
Oct 26, 2020
...rules/src/test/resources/test/paragraph6/abstract_classes/ShouldRemoveAbstractKeywordTest.kt
Show resolved
Hide resolved
### What's done: * Fixed bugs
petertrr
requested changes
Oct 26, 2020
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/classes/AbstractClassesRule.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/classes/AbstractClassesRule.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/classes/AbstractClassesRule.kt
Outdated
Show resolved
Hide resolved
### What's done: * Fixed bugs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
This pull request closes #442
Actions checklist