Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPE is ASTNode.squeezeSpaces method #500

Merged
merged 8 commits into from
Nov 16, 2020

Conversation

kentr0w
Copy link
Collaborator

@kentr0w kentr0w commented Nov 6, 2020

What's done:

Fixed bug
closes #460

### What's done:
   Fixed bug
@kentr0w kentr0w added the bug Something isn't working label Nov 6, 2020
@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #500 (e031d16) into master (c5adb74) will decrease coverage by 0.08%.
The diff coverage is 82.14%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #500      +/-   ##
============================================
- Coverage     81.79%   81.70%   -0.09%     
- Complexity     1596     1600       +4     
============================================
  Files            76       76              
  Lines          4026     4034       +8     
  Branches       1278     1282       +4     
============================================
+ Hits           3293     3296       +3     
- Misses          215      218       +3     
- Partials        518      520       +2     
Flag Coverage Δ Complexity Δ
unittests 81.70% <82.14%> (-0.09%) 0.00 <20.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...fn/diktat/ruleset/rules/kdoc/CommentsFormatting.kt 68.66% <82.14%> (-1.76%) 75.00 <20.00> (+4.00) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5adb74...e031d16. Read the comment docs.

### What's done:
  Made a little prettier
### What's done:
  Made a little prettier
Copy link
Member

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, the issue was with top-level block comments? Can it happen with other types of comments?

### What's done:
  Renamed
@kentr0w
Copy link
Collaborator Author

kentr0w commented Nov 9, 2020

No, I tested with EOL_COMMENT and KDOC and now there are no problems

### What's done:
    Fixed bug
### What's done:
   Fixed after review
### What's done:
   Fixed bugs
@kentr0w kentr0w merged commit 370a981 into master Nov 16, 2020
@petertrr petertrr deleted the bugfix/npe-smokeTest-squeezeSpaces branch November 18, 2020 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPE is ASTNode.squeezeSpaces method
2 participants