-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created tests for diktat-gradle-plugin #561
Conversation
### What's done: * Added tests * Added jacoco config
Codecov Report
@@ Coverage Diff @@
## master #561 +/- ##
=========================================
Coverage 81.68% 81.68%
- Complexity 1641 1652 +11
=========================================
Files 79 83 +4
Lines 4139 4205 +66
Branches 1307 1312 +5
=========================================
+ Hits 3381 3435 +54
- Misses 229 238 +9
- Partials 529 532 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
### What's done: * Added tests * Added jacoco config
### What's done: * Added tests
### What's done: * Added tests
@Test | ||
fun `test gradle version`() { | ||
Assertions.assertEquals( | ||
GradleVersion.fromString("6.6.1"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do you need to test gradle version. It can be changed in any moment. No?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm testing my GradleVersion
class, which is used to determine which type of task is supported by current gradle.
diktat-gradle-plugin/src/test/kotlin/org/cqfn/diktat/plugin/gradle/DiktatJavaExecTaskTest.kt
Outdated
Show resolved
Hide resolved
<executable>${gradle.executable}</executable> | ||
<arguments> | ||
<argument>clean</argument> | ||
<argument>jacocoTestReport</argument> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do you need test report here? For test coverage?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this tasks will execute test
and then generate jacoco report.
### What's done: * Post-review notes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What's done:
This pull request closes #542