Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private property in KDoc #575

Merged
merged 4 commits into from
Nov 27, 2020
Merged

Private property in KDoc #575

merged 4 commits into from
Nov 27, 2020

Conversation

kentr0w
Copy link
Collaborator

@kentr0w kentr0w commented Nov 26, 2020

What's done:

Fixed bug, added tests
closes #552

### What's done:
   Fixed bug, added tests
@kentr0w kentr0w added the bug Something isn't working label Nov 26, 2020
### What's done:
   Fixed test
@codecov
Copy link

codecov bot commented Nov 26, 2020

Codecov Report

Merging #575 (0896b6f) into master (5426cd4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #575   +/-   ##
=========================================
  Coverage     80.73%   80.74%           
- Complexity     1702     1703    +1     
=========================================
  Files            87       87           
  Lines          4345     4346    +1     
  Branches       1340     1340           
=========================================
+ Hits           3508     3509    +1     
  Misses          299      299           
  Partials        538      538           
Flag Coverage Δ Complexity Δ
unittests 80.74% <100.00%> (+<0.01%) 0.00 <2.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...org/cqfn/diktat/ruleset/rules/kdoc/KdocComments.kt 82.45% <100.00%> (+0.15%) 62.00 <2.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5426cd4...0896b6f. Read the comment docs.

Copy link
Member

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

### What's done:
    Added more tests
@kentr0w kentr0w merged commit 07829e0 into master Nov 27, 2020
@kentr0w kentr0w deleted the bugfix/kdoc-private-property branch November 27, 2020 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KDoc for private properties are added only when there was no KDoc (also warning)
2 participants