Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling empty inputs in diktat-gradle-plugin #611

Merged
merged 1 commit into from
Dec 4, 2020

Conversation

petertrr
Copy link
Member

@petertrr petertrr commented Dec 4, 2020

What's done:

  • Changed logic
  • Added tests

This pull request closes #572

### What's done:
* Changed logic
* Added tests
@codecov
Copy link

codecov bot commented Dec 4, 2020

Codecov Report

Merging #611 (ccb78dc) into master (123e9d4) will decrease coverage by 0.00%.
The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #611      +/-   ##
============================================
- Coverage     81.26%   81.25%   -0.01%     
- Complexity     1722     1723       +1     
============================================
  Files            87       87              
  Lines          4548     4551       +3     
  Branches       1361     1361              
============================================
+ Hits           3696     3698       +2     
- Misses          306      308       +2     
+ Partials        546      545       -1     
Flag Coverage Δ Complexity Δ
unittests 81.25% <75.00%> (-0.01%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...qfn/diktat/plugin/gradle/DiktatJavaExecTaskBase.kt 76.19% <75.00%> (-0.74%) 7.00 <0.00> (+1.00) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 123e9d4...ccb78dc. Read the comment docs.

Copy link
Collaborator

@kentr0w kentr0w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@petertrr petertrr merged commit 6d31422 into master Dec 4, 2020
@petertrr petertrr deleted the feature/diktat-gradle-plugin-in-multimodule#572 branch December 4, 2020 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix diktat-gradle-plugin behavior in multiproject builds
2 participants