Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed file path from warning messages #621

Merged
merged 7 commits into from
Dec 9, 2020

Conversation

petertrr
Copy link
Member

@petertrr petertrr commented Dec 8, 2020

What's done:

  • Changed code
  • Changed tests

This pull request closes #619

### What's done:
* Changed code
* Changed tests
@petertrr petertrr requested review from kentr0w and aktsay6 December 8, 2020 15:10
@codecov
Copy link

codecov bot commented Dec 8, 2020

Codecov Report

Merging #621 (6849dd0) into master (ac07d98) will increase coverage by 0.00%.
The diff coverage is 84.21%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #621   +/-   ##
=========================================
  Coverage     80.75%   80.76%           
  Complexity     1748     1748           
=========================================
  Files            89       89           
  Lines          4615     4612    -3     
  Branches       1386     1391    +5     
=========================================
- Hits           3727     3725    -2     
+ Misses          322      320    -2     
- Partials        566      567    +1     
Flag Coverage Δ Complexity Δ
unittests 80.76% <84.21%> (+<0.01%) 0.00 <4.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...org/cqfn/diktat/ruleset/rules/kdoc/KdocComments.kt 79.68% <50.00%> (ø) 70.00 <0.00> (ø)
...fn/diktat/ruleset/rules/files/FileStructureRule.kt 81.57% <66.66%> (-1.03%) 55.00 <0.00> (ø)
...in/org/cqfn/diktat/ruleset/rules/files/FileSize.kt 77.27% <71.42%> (+10.60%) 8.00 <0.00> (-1.00) ⬆️
...diktat/ruleset/rules/comments/HeaderCommentRule.kt 84.88% <81.81%> (-1.71%) 38.00 <0.00> (+1.00) ⬇️
...org/cqfn/diktat/ruleset/rules/AvoidUtilityClass.kt 71.42% <100.00%> (ø) 15.00 <0.00> (ø)
...kotlin/org/cqfn/diktat/ruleset/rules/FileNaming.kt 90.47% <100.00%> (ø) 8.00 <3.00> (ø)
...lin/org/cqfn/diktat/ruleset/rules/PackageNaming.kt 94.04% <100.00%> (+0.07%) 32.00 <1.00> (ø)
...cqfn/diktat/ruleset/rules/files/IndentationRule.kt 86.40% <100.00%> (ø) 25.00 <0.00> (ø)
...g/cqfn/diktat/ruleset/rules/kdoc/KdocFormatting.kt 76.66% <100.00%> (-0.31%) 73.00 <0.00> (ø)
.../org/cqfn/diktat/ruleset/rules/kdoc/KdocMethods.kt 85.29% <100.00%> (ø) 70.00 <0.00> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac07d98...ef4b15b. Read the comment docs.

### What's done:
* diktat codestyle
### What's done:
* Review notes
### What's done:
* Review notes
@petertrr petertrr merged commit d2223c5 into master Dec 9, 2020
@petertrr petertrr deleted the feature/remove-file-path-warnigs#619 branch December 9, 2020 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove file paths from diktat warning messages
3 participants