Bugfix in the LineLength rule #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #929 +/- ##
=========================================
Coverage 84.14% 84.14%
Complexity 2373 2373
=========================================
Files 101 101
Lines 6006 6006
Branches 1772 1772
=========================================
Hits 5054 5054
Misses 263 263
Partials 689 689
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
petertrr
approved these changes
Jun 16, 2021
| } | ||
|
|
||
| private fun validateAccessors(node: ASTNode, propsWithBackSymbol: List<String>) { | ||
| val accessors = node.findAllDescendantsWithSpecificType(PROPERTY_ACCESSOR).filter { it.hasChildOfType(BLOCK) } // exclude get with expression body |
There was a problem hiding this comment.
Is this the line that caused an error? Could you make this example more minimal, e.g. the logic function doesn't have anything to do with line length here.
There was a problem hiding this comment.
Thanks, agree, now this test is more compact
### What's done: * Minimize test
…bugfix/line_length_bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
Explanation:
When we looking for the node, which code len is greater than limit, we should keep in mind, that
if
limit = 120, it means, that the119symbol, i.e.119element from code line array exceeds the limit.But previously, in
we took the
120element, which offset is actually121and so NPE appeared insince
configuration.lineLength.toInt() == 120andleftOffset == 121