Fixes in code style, update documentation #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * Added rule 3.16.2 verbose description * Fixed typos in rule 6.2.2
### What's done: * Updated docs * Fixed and updated gradle scripts for docs generation
Codecov Report
@@ Coverage Diff @@
## master #930 +/- ##
=========================================
Coverage 84.15% 84.15%
Complexity 2374 2374
=========================================
Files 101 101
Lines 6008 6008
Branches 1773 1773
=========================================
Hits 5056 5056
Misses 263 263
Partials 689 689
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
petertrr
changed the title
orchestr7
reviewed
Jun 21, 2021
| @@ -857,13 +863,14 @@ If the classes are meant to be used externally, and are not referenced inside th | |||
| - Companion object | |||
|
|
|||
| **Exception:** | |||
| All variants of a `(private) val` logger should be placed at the beginning of the class (`(private) val log`, `LOG`, `logger`, etc.). | |||
| All variants of a `private val` logger should be placed at the beginning of the class (`private val log`, `LOG`, `logger`, etc.). | |||
orchestr7
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
This pull request closes #928