Kdoc fixer false-negative: not generating a Kdoc for several public functions #989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cheshiriks
force-pushed
the
bugfix/Kdoc-fixer-false-negative
branch
from
347b8ba to
9ae14fd
Compare
Codecov Report
@@ Coverage Diff @@
## master #989 +/- ##
============================================
+ Coverage 83.81% 83.85% +0.03%
- Complexity 2409 2416 +7
============================================
Files 102 102
Lines 6081 6094 +13
Branches 1799 1802 +3
============================================
+ Hits 5097 5110 +13
Misses 269 269
Partials 715 715
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Cheshiriks
force-pushed
the
bugfix/Kdoc-fixer-false-negative
branch
from
bd52ae0 to
bbc57ec
Compare
petertrr
requested changes
Jul 19, 2021
There was a problem hiding this comment.
Please provide a more detailed description in the PR, to summarize what we are changing here. We are changing criterion for getters and setters and changing expression body detection, right?
Also please check out and fix newly discovered rules violations in diktat_snapshot workflow
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter2/kdoc/KdocMethods.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter2/kdoc/KdocMethods.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter2/kdoc/KdocMethods.kt
Outdated
Show resolved
Hide resolved
petertrr
approved these changes
Jul 19, 2021
…unctions ### What's done: * fixed bug in MISSING_KDOC_ON_FUNCTION Closes #965
…unctions ### What's done: * fixed bug in MISSING_KDOC_ON_FUNCTION Closes #965
…unctions ### What's done: * fixed bug in MISSING_KDOC_ON_FUNCTION Closes #965
…unctions ### What's done: * fixed bug in MISSING_KDOC_ON_FUNCTION Closes #965
…unctions ### What's done: * fixed bug in MISSING_KDOC_ON_FUNCTION Closes #965
…unctions ### What's done: * fixed bug in MISSING_KDOC_ON_FUNCTION Closes #965
…unctions ### What's done: * fixed bug in MISSING_KDOC_ON_FUNCTION Closes #965
Cheshiriks
force-pushed
the
bugfix/Kdoc-fixer-false-negative
branch
from
1520b81 to
469d1ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
Closes Kdoc fixer false-negative: not generating a Kdoc for several public functions #965