multiplexed socket: avoid use-after-free

Change-Id: I0c093ea4e1834866fd08abb30d51d5043fe1f455
savoirfairelinux · Jan 17, 2025 · f0f834d · f0f834d
1 parent d16f816
commit f0f834d
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/src/multiplexed_socket.cpp b/src/multiplexed_socket.cpp
@@ -226,11 +226,15 @@ class MultiplexedSocket::Impl
 void
 MultiplexedSocket::Impl::eventLoop()
 {
-    endpoint->setOnStateChange([this](tls::TlsSessionState state) {
-        if (state == tls::TlsSessionState::SHUTDOWN && !isShutdown_) {
-            if (logger_)
-                logger_->debug("Tls endpoint is down, shutdown multiplexed socket");
-            shutdown();
+    endpoint->setOnStateChange([w = parent_.weak_from_this()](tls::TlsSessionState state) {
+        auto ssock = w.lock();
+        if (!ssock)
+            return false;
+        auto& this_ = *ssock->pimpl_;
+        if (state == tls::TlsSessionState::SHUTDOWN && !this_.isShutdown_) {
+            if (this_.logger_)
+                this_.logger_->debug("Tls endpoint is down, shutdown multiplexed socket");
+            this_.shutdown();
             return false;
         }
         return true;