1.9 fixes #193
Merged
1.9 fixes #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namespace name.
The bug only showed up in Ruby 1.9 because we had been accidentally
calling [:Save, {}].to_s and hoping to get "Save" (which happens to
work in 1.8).
to believe the namespaces implied by the WSDL, rather than one which the Savon caller explicitly specified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch fixes the spec failures on 1.9. Turns out that the namespace name being used was a red herring, and the real problem was in the code, not in the spec. It had been (accidentally) calling [:Save, {}].to_s and wanting to get "Save" which works in 1.8 and not 1.9. This patch includes the spec changes (which seem to make the spec a bit more robust, I guess), the bugfix, and another spec which had been marked pending since the start of the multiple namespace code.