fixed problem with port_message part in case there is no namespace set #38
Conversation
|
Hey @dabooze your change looks good, it's fairly straightforward. Would you mind adding a simple test for this? |
|
Actually, this part of the code is currently causing problems for Savon, see #32 and savonrb/savon#520 I'd hold off on writing any tests until we get this sorted out. |
|
Interesting. Ok I'll wait until it's clear whether the Wasabi patch should be rolled back or Savon code needs changes. |
|
My impression is that this fix is valid, but that we need to be more careful when we use the operation name rather than the port_message name. Each time I look into this, I understand the issue a little more, but it's still rather opaque as to what the correct behavior is in all cases. Thank you for understanding! |
Huge thanks to @dabooze for being patient while we sorted out the fiasco with the regression from several months ago and fixed this up. So glad that this has been resolved now.
|
I had to merge this in by hand because of the recent changes to Thank you so much for issuing this pull request @dabooze. If you can, and you'd like to add your WSDL (or a similar WSDL) as a fixture and write some better tests for this behavior, I'd be more than happy to merge that in. The tests I added in 64fe56a aren't the best. There was an example WSDL already in the project and I made a new operation that matched what I expected an operation with a port message but no colon for a namespace would look like (based on some other WSDLs I've seen). |
Some WSDL's don't have a namespace set (separated by a colon) in the operation names and hence this needs to be taken care if in order to successfully determine the correct message name for sending out the SOAP request.