Refactor #152
Merged
Refactor #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@savq little ping to remind you to merge this so I can work on the next items. |
savq
force-pushed
the
refactor
branch
2 times, most recently
from
5e45ac6 to
8224bb7
Compare
Public API: - Rename `run` option to `build`. - Rename `PaqRunHook` command to `PaqBuild`. Paq will print a deprecation notice if the old names are used. The reason for renaming these is explained in #143. Internals: - Refactor build related functions to ensure builds are executed after all packages have been installed/updated and loaded: - If the hook is a function, it might require a module inside a recently installed package. - If a is package is installed successfully and the build fails, it's better to notify that in two separate messages, instead of notifying the install failed. - Rename `run_hook` to `run_build`, and refactor to make it clear there's 3 possible cases: function, ex command, shell commmand. - Refactor `new_counter` to take a callback (passed in `exe_op`).
- Refactor `report` and `counter` to have (almost) the same signature. - Refactor the weird logic used to handle `PaqSync` messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paq*commands.reportandcounterto have a similar signature.PaqSyncmessages.runoption tobuild.PaqRunHookcommand toPaqBuild. Paq will print a deprecation notice if the old names are used. The reason for renaming is explained in Unable to run setup hook for gitsigns #143.NOTE: I removed from the PR the refactor to
call_proc, since it didn't seem to be working correctly.