Skip to content

Commit

Permalink
clean up code
Browse files Browse the repository at this point in the history
  • Loading branch information
koebel committed Apr 12, 2024
1 parent 715b8de commit 5c070f5
Showing 1 changed file with 2 additions and 8 deletions.
10 changes: 2 additions & 8 deletions tests/e2e/steps/ViewerContext.ts
Original file line number Diff line number Diff line change
Expand Up @@ -85,31 +85,25 @@ Then('the 3D model should be display in standard mode', async function (): Promi

When('the user rotates the model', async function (): Promise<void> {
await viewer.modifyModelRotation()
// for testing only to see the interaction take place
await delay(1000)
})

When('the user zooms into the model', async function (): Promise<void> {
await viewer.modifyModelZoom()
// for testing only to see the interaction take place
await delay(1000)
})

Then('the size and position of the 3D model will be changed accordingly', function () {
// not sure how to test this? maybe check if rotation and zoom factor differ from original position?
// check if camera.position and camera.position.z have been modified (!= initCamPosition)
// check if camera.position and camera.position.z have been modified (!= initCamPosition)?
return 'pending'
})

When('the user resets the viewport', async function (): Promise<void> {
await viewer.resetViewport()
// for testing only to see the interaction take place
await delay(1000)
})

Then('the 3D model should be display in the default size and position', function () {
// not sure how to test this?
// check if camera.position and camera.position.z are equal to initCamPosition
// check if camera.position and camera.position.z are equal to initCamPosition?
return 'pending'
})

Expand Down

0 comments on commit 5c070f5

Please sign in to comment.