Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

asyncio and non-blocking UDP, rhythm support, performance optimizations, refactoring #2

Merged
merged 1 commit into from
Mar 18, 2020
Merged

asyncio and non-blocking UDP, rhythm support, performance optimizations, refactoring #2

merged 1 commit into from
Mar 18, 2020

Conversation

angadsingh
Copy link
Contributor

  • Fixes UDP async error wiz_light#6: make the whole component truly async using non-blocking UDP
  • Light control now works even when lights are set to a rhythm.

Features:

  • Now supports switching the light to rhythm mode! (rhythm is defined as a scene for HA)
  • Implements a pattern of sending multiple command UDP datagrams until response is received
  • Consolidates getPilot and setPilot calls using a PilotBuilder and PilotParser. Removes unnecessary UDP calls for each and every attribute (color, temperature, brightness, scene, etc.) and makes a combined getPilot/setPilot call
  • enhanced debug logging for UDP

@angadsingh
Bug fixes:
6b1eea5 
- Fixes sbidy#6: make the whole component truly async using non-blocking UDP
- Light control now works even when lights are set to a rhythm.

Features:
- Now supports switching the light to rhythm mode! (rhythm is defined as a scene for HA)
- Implements a pattern of sending multiple command UDP datagrams until response is received
- Consolidates getPilot and setPilot calls using a PilotBuilder and PilotParser. Removes unnecessary UDP calls for each and every attribute (color, temperature, brightness, scene, etc.) and makes a combined getPilot/setPilot call
- enhanced debug logging for UDP
@angadsingh angadsingh changed the title Bug fixes: asyncio and non-blocking UDP, rhythm support, performance optimizations, refactoring Mar 18, 2020
@angadsingh angadsingh mentioned this pull request Mar 18, 2020
Merged
@sbidy sbidy merged commit cc439b0 into sbidy:master Mar 18, 2020
sbidy pushed a commit that referenced this pull request Jul 6, 2021
@SvbZ3r0
Merge pull request #2 from SvbZ3r0/fix-typos
64d8929 
Typos and bug fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UDP async error
2 participants
@angadsingh @sbidy