Skip to content
This repository has been archived by the owner on Mar 8, 2022. It is now read-only.

Bug fixes and improvements #8

Merged
merged 1 commit into from
Mar 18, 2020
Merged

Bug fixes and improvements #8

merged 1 commit into from
Mar 18, 2020

Conversation

angadsingh
Copy link
Contributor

  • Fixes UDP async error #6: make the whole component truly async using non-blocking UDP
  • Light control now works even when lights are set to a rhythm.
    Features:
  • Now supports switching the light to rhythm mode! (rhythm is defined as a scene for HA)
  • Implements a pattern of sending multiple command UDP datagrams until response is received
  • Consolidates getPilot and setPilot calls using a PilotBuilder and PilotParser. Removes unnecessary UDP calls for each and every attribute (color, temperature, brightness, scene, etc.) and makes a combined getPilot/setPilot call
  • enhanced debug logging for UDP

@angadsingh
Bug fixes:
caa90ce 
- Fixes #6: make the whole component truly async using non-blocking UDP
- Light control now works even when lights are set to a rhythm.

Features:
- Now supports switching the light to rhythm mode! (rhythm is defined as a scene for HA)
- Implements a pattern of sending multiple command UDP datagrams until response is received
- Consolidates getPilot and setPilot calls using a PilotBuilder and PilotParser. Removes unnecessary UDP calls for each and every attribute (color, temperature, brightness, scene, etc.) and makes a combined getPilot/setPilot call
- enhanced debug logging for UDP
@sbidy
Copy link
Owner

sbidy commented Mar 18, 2020

Awesome work! Thank you!
I want to merge this pull but we should transfer the improvements in the pywizlight into the corresponding repo. to provide a pip package regarding the implementation guide from HA.

My plan is to have the pywizlight sync. and async to provide the lib also for other projects.

@sbidy sbidy self-requested a review March 18, 2020 08:19
@angadsingh
Copy link
Contributor Author

will send separate PRs soon. this was just for your pre-approval. Also let me test this out for a week to iron out any bugs! :)

@sbidy sbidy changed the base branch from master to testing March 18, 2020 08:27
sbidy
sbidy approved these changes Mar 18, 2020
View reviewed changes
Copy link
Owner

@sbidy sbidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done - move to testing branch

@sbidy sbidy merged commit e2c8bb0 into sbidy:testing Mar 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sbidy sbidy sbidy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UDP async error
2 participants
@angadsingh @sbidy