-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hplip support #384
hplip support #384
Conversation
Dockerfile
Outdated
&& apt-get clean \ | ||
&& rm -rf /var/lib/apt/lists/* | ||
|
||
RUN echo hpaio >> /etc/sane.d/dll.conf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about, instead of here, adding something like this to the end...
# hplib image
#
# This image adds the HP scanner libs to the image.
# ==============================================================================
FROM scanservjs-core AS scanservjs-hplib
RUN apt-get install -yq \
libsane-hpaio \
&& apt-get clean \
&& rm -rf /var/lib/apt/lists/* \
&& echo hpaio >> /etc/sane.d/dll.conf
It won't get included by default but allows users to build their own by specifying target
. There could be a similar approach for brother images. I haven't tested this but assume it would work.
Github workflow now only builds from v* tags and targets more platforms.
0248472
to
8ae1c9d
Compare
Thanks Sam, i've made that change now and created a versioned multi platform build on dockerhub. I've added some notes to the readme on my fork so it can standalone, so you won't want all the changes verbatim from that branch. Shall i close this PR now? |
This is very cool - I've simply not had time to look at this before. So by adding - name: Set up QEMU for multi-platform build
uses: docker/setup-qemu-action@v1 and platforms: linux/amd64,linux/arm64,linux/arm/v7 The workflow magically takes care of multi-platform builds yes? Then there's the other stuff related to the hplib. Thank you for taking the time to do this. It also gives us a way of dealing with brother scanners. |
Yes those 3 extra lines give the cross platform builds. It takes about 30mins to build all 3. |
Thank you so much for this. I have integrated the multi architecture builds (which is a huge bonus!) and added the hplib target. That target is not built by default but at least your custom build is smaller now. |
Thanks for integrating this, and for all the work you've put into this amazing project :) |
This is tested to work on an ODroid HC2 (--platform linux/arm/v7). Not sure if this would be better as a separate docker referencing scanservjs-core?