chore: Cleanup more unused warnings.

* chore: Upgrade to Scala 3.3.0-RC2, cleanup * Clean-up j17. * chore: Cleanup more unused warnings. * Cleanup benchmarks and Library17
scala-interop · Feb 10, 2023 · b35bae7 · b35bae7
1 parent 09a719b
commit b35bae7
Show file tree

Hide file tree

Showing 25 changed files with 57 additions and 135 deletions.
diff --git a/build.sc b/build.sc
@@ -11,24 +11,14 @@ import com.github.lolgab.mill.mima._
 import $ivy.`com.lihaoyi::mill-contrib-scoverage:`
 import mill.contrib.scoverage.{ScoverageModule, ScoverageReport}
 
-object v {
-  val munit = "1.0.0-M6"
-  val jmh = "1.33"
-  val jnr = "2.2.3"
-  val jna = "5.9.0"
-  val scoverage = "1.4.0"
-}
-
 object scoverage extends BaseModule with ScoverageReport 
 
 trait BaseModule extends ScoverageModule with ScalafmtModule {
   def scalaVersion = "3.3.0-RC2"
   def scoverageVersion = "2.0.7"
 
-  val munitVersion = "1.0.0-M6"
+  val munitVersion = "1.0.0-M7"
   val jmhV = "1.33"
-  val jnr = "2.2.3"
-  val jna = "5.9.0"
 
   def ivyDeps = Agg(
     ivy"org.scala-lang::scala3-staging:${scalaVersion()}"
@@ -164,11 +154,6 @@ object `runtime` extends BaseModule with PublishableModule {
 
   override def moduleDeps = Seq(j17, j19)
 
-  // override def ivyDeps = Agg(
-  //   ivy"fr.hammons::slinc-j17:${publishVersion()}",
-  //   ivy"fr.hammons::slinc-j19:${publishVersion()}"
-  // )
-
   object test extends Tests with TestModule.Munit {
     def ivyDeps = Agg(ivy"org.scalameta::munit:$munitVersion")
 

diff --git a/core/src/fr/hammons/slinc/Fn.scala b/core/src/fr/hammons/slinc/Fn.scala
@@ -25,7 +25,9 @@ object Fn:
     toNativeCompatibleImpl('a)
   }
 
-  @nowarn
+  // todo: remove once https://github.com/lampepfl/dotty/issues/16863 is fixed
+  @nowarn("msg=unused implicit parameter")
+  @nowarn("msg=unused local definition")
   def toNativeCompatibleImpl[A](a: Expr[A])(using Quotes, Type[A]): Expr[A] =
     import quotes.reflect.*
     val typeArgs = TypeRepr.of[A].typeArgs

diff --git a/core/src/fr/hammons/slinc/LibraryI.scala b/core/src/fr/hammons/slinc/LibraryI.scala
@@ -108,7 +108,6 @@ object LibraryI:
   // todo: get rid of this once bug https://github.com/lampepfl/dotty/issues/16863 is fixed
   @nowarn("msg=unused implicit parameter")
   @nowarn("msg=unused local definition")
-  @nowarn("msg=unused explicit parameter")
   def bindingImpl[R, L[_] <: LibraryI#Library[?]](using q: Quotes)(using
       Type[R],
       Type[L]
@@ -170,7 +169,7 @@ object LibraryI:
         }
     val rTransition: Expr[Object | Null => R] = Type.of[R] match
       case '[Unit] =>
-        '{ (obj: Object | Null) => () }.asExprOf[Object | Null => R]
+        '{ (_: Object | Null) => () }.asExprOf[Object | Null => R]
       case '[r] =>
         Expr
           .summon[DescriptorOf[R]]
@@ -279,7 +278,7 @@ object LibraryI:
   )(using Quotes, Type[L]) =
     val name: LibraryLocation = LibraryName.libraryName[L]
     name match
-      case LibraryLocation.Standardard =>
+      case LibraryLocation.Standard =>
         '{ $platformSpecificExpr.getStandardLibLookup }
       case LibraryLocation.Local(s) =>
         '{ $platformSpecificExpr.getLocalLookup(${ Expr(s) }) }

diff --git a/core/src/fr/hammons/slinc/LibraryName.scala b/core/src/fr/hammons/slinc/LibraryName.scala
@@ -2,14 +2,17 @@ package fr.hammons.slinc
 
 import scala.annotation.StaticAnnotation
 import scala.quoted.*
+import scala.annotation.nowarn
 
-class LibraryName(name: String) extends StaticAnnotation
+class LibraryName(val name: String) extends StaticAnnotation
 
+//todo: remove this once https://github.com/lampepfl/dotty/issues/16878 is fixed
+@nowarn("msg=unused explicit parameter")
 enum LibraryLocation:
   case Local(s: String)
   case Resource(s: String)
   case Path(s: String)
-  case Standardard
+  case Standard
 
 object LibraryName:
   def libraryName[L](using Quotes, Type[L]) =
@@ -29,4 +32,4 @@ object LibraryName:
         case s         => LibraryLocation.Local(s)
       }
       .headOption
-      .getOrElse(LibraryLocation.Standardard)
+      .getOrElse(LibraryLocation.Standard)
diff --git a/core/src/fr/hammons/slinc/Lookup.scala b/core/src/fr/hammons/slinc/Lookup.scala
@@ -6,7 +6,7 @@ trait Lookup(libraryLocation: LibraryLocation):
   def lookup(name: String): Object
 
   def lookupError(name: String): Error = libraryLocation match
-    case LibraryLocation.Standardard =>
+    case LibraryLocation.Standard =>
       Error(s"Failed to load symbol $name from the standard library.")
     case LibraryLocation.Resource(location) =>
       Error(

diff --git a/core/src/fr/hammons/slinc/MacroHelpers.scala b/core/src/fr/hammons/slinc/MacroHelpers.scala
@@ -1,8 +1,12 @@
 package fr.hammons.slinc
 
 import scala.quoted.*
+import scala.annotation.nowarn
 
 private[slinc] object MacroHelpers:
+  // todo: remove once https://github.com/lampepfl/dotty/issues/16863 is fixed
+  @nowarn("msg=unused local definition")
+  @nowarn("msg=unused implicit parameter")
   def widenExpr(t: Expr[?])(using Quotes) =
     import quotes.reflect.*
     t match

diff --git a/core/src/fr/hammons/slinc/Ptr.scala b/core/src/fr/hammons/slinc/Ptr.scala
@@ -1,17 +1,13 @@
 package fr.hammons.slinc
 
-import scala.util.TupledFunction
-import scala.annotation.experimental
-import scala.annotation.targetName
-import scala.compiletime.{erasedValue, summonInline}
 import scala.reflect.ClassTag
 import fr.hammons.slinc.modules.DescriptorModule
 
 class Ptr[A](private[slinc] val mem: Mem, private[slinc] val offset: Bytes):
   def `unary_!`(using receive: Receive[A]): A = receive.from(mem, offset)
-  def asArray(size: Int)(using
-      ClassTag[A]
-  )(using DescriptorOf[A], DescriptorModule)(using r: ReceiveBulk[A]) =
+  def asArray(size: Int)(using DescriptorOf[A], DescriptorModule)(using
+      r: ReceiveBulk[A]
+  ) =
     r.from(mem.resize(DescriptorOf[A].size * size), offset, size)
 
   def `unary_!_=`(value: A)(using send: Send[A]) = send.to(mem, offset, value)

diff --git a/core/src/fr/hammons/slinc/Receive.scala b/core/src/fr/hammons/slinc/Receive.scala
@@ -9,6 +9,7 @@ import fr.hammons.slinc.modules.DescriptorModule
 import scala.annotation.nowarn
 
 class ReceiveI(val libraryPs: LibraryI.PlatformSpecific):
+  // todo: replace with `erased` once that's not experimental anymore
   @nowarn("msg=unused implicit parameter")
   inline given fnReceive[A](using Fn[A, ?, ?]): Receive[A] =
     new Receive[A]:

diff --git a/core/src/fr/hammons/slinc/Send.scala b/core/src/fr/hammons/slinc/Send.scala
@@ -1,12 +1,12 @@
 package fr.hammons.slinc
 
 import scala.quoted.*
-import scala.annotation.targetName
 import scala.deriving.Mirror
-import scala.compiletime.{erasedValue, summonInline}
+import scala.compiletime.summonInline
 import scala.util.chaining.*
 import fr.hammons.slinc.container.{ContextProof, *:::, End}
 import fr.hammons.slinc.modules.DescriptorModule
+import scala.annotation.nowarn
 
 trait Send[A]:
   def to(mem: Mem, offset: Bytes, value: A): Unit
@@ -33,11 +33,16 @@ object Send:
         }
       ).asInstanceOf[Send[A]]
 
+  // todo: get rid of this once bug https://github.com/lampepfl/dotty/issues/16863 is fixed
+  @nowarn("msg=unused implicit parameter")
   private def asExprOf[A](expr: Expr[Any])(using Quotes, Type[A]) =
     import quotes.reflect.*
     if expr.isExprOf[A] then expr.asExprOf[A]
     else '{ $expr.asInstanceOf[A] }
 
+  // todo: get rid of this once bug https://github.com/lampepfl/dotty/issues/16863 is fixed
+  @nowarn("msg=unused implicit parameter")
+  @nowarn("msg=unused local definition")
   private def stagedHelper(
       layout: TypeDescriptor,
       mem: Expr[Mem],
@@ -142,15 +147,15 @@ object Send:
       case _: EmptyTuple => ()
 
   given Send[Int] with
-    inline def to(mem: Mem, offset: Bytes, value: Int) =
+    def to(mem: Mem, offset: Bytes, value: Int) =
       mem.writeInt(value, offset)
 
   given Send[Float] with
-    inline def to(mem: Mem, offset: Bytes, value: Float) =
+    def to(mem: Mem, offset: Bytes, value: Float) =
       mem.writeFloat(value, offset)
 
   given Send[Long] with
-    inline def to(mem: Mem, offset: Bytes, value: Long) =
+    def to(mem: Mem, offset: Bytes, value: Long) =
       mem.writeLong(value, offset)
 
   given Send[Double] with

diff --git a/core/src/fr/hammons/slinc/SlincImpl.scala b/core/src/fr/hammons/slinc/SlincImpl.scala
@@ -4,8 +4,7 @@ import scala.annotation.StaticAnnotation
 import scala.quoted.*
 import scala.annotation.nowarn
 
-@nowarn("msg=unused explicit parameter")
-class SlincImpl(version: Int) extends StaticAnnotation
+class SlincImpl(val version: Int) extends StaticAnnotation
 
 object SlincImpl:
   inline def findImpls(): Map[Int, () => Slinc] = ${

diff --git a/core/src/fr/hammons/slinc/Struct.scala b/core/src/fr/hammons/slinc/Struct.scala
@@ -7,7 +7,6 @@ import scala.compiletime.{
   summonInline,
   constValueTuple
 }
-import java.util.concurrent.atomic.AtomicReference
 import scala.reflect.ClassTag
 import modules.DescriptorModule
 import fr.hammons.slinc.modules.TransitionModule

diff --git a/core/src/fr/hammons/slinc/Tools.scala b/core/src/fr/hammons/slinc/Tools.scala
@@ -1,14 +1,7 @@
 package fr.hammons.slinc
 
-import java.nio.file.{Files, Paths, Path}
+import java.nio.file.{Files, Paths}
 import types.{os, OS}
-import java.security.MessageDigest
-import java.util.HexFormat
-import fr.hammons.slinc.types.OS
-import fr.hammons.slinc.types.OS
-import java.nio.channels.Channel
-import java.nio.channels.ByteChannel
-import java.nio.channels.Channels
 import scala.sys.process.*
 
 object Tools:
@@ -20,6 +13,8 @@ object Tools:
         case OS.Linux => s"${System.getProperty("user.home").nn}/.cache/slinc/"
         case OS.Darwin =>
           s"${System.getProperty("user.home").nn}/Library/Application Support/"
+        // todo: write a better handling for this
+        case OS.Unknown => ???
       )
       .nn
 

diff --git a/core/src/fr/hammons/slinc/container/ContextProof.scala b/core/src/fr/hammons/slinc/container/ContextProof.scala
@@ -1,11 +1,8 @@
 package fr.hammons.slinc.container
 
-import scala.compiletime.ops.int.+
 import scala.compiletime.constValue
 import scala.compiletime.summonAll
-import scala.compiletime.erasedValue
-import scala.compiletime.error
-import scala.quoted.*
+import scala.annotation.nowarn
 
 class ContextProof[C <: Capabilities, A](val tup: ContextProof.ToTuple[C, A])
 
@@ -18,14 +15,11 @@ object ContextProof:
     case head *::: tail => head[T] *: ToTuple[tail, T]
     case End            => EmptyTuple
 
+  // todo: replace with `erased` for l once that's not experimental
+  @nowarn("msg=unused implicit parameter")
   inline given reducedProof[A, Cap <: Capabilities, C[_], N <: Int](using
       c: ContextProof[Cap, A],
       l: LocationInCap[C, Cap, N]
   ): ContextProof[C *::: End, A] = new ContextProof(
     (c.tup.productElement(constValue[N]).asInstanceOf[C[A]]) *: EmptyTuple
   )
-
-  // given conversionFromProof[A,B](using c: ContextProof[Conversion[*,B] *::: End, A]): Conversion[A,B] = c.tup.head
-  // given unconversionFromProof[A,B](using c: ContextProof[Conversion[B,*] *::: End,A]): Conversion[B,A] = c.tup.head
-
-  // given equalityProof[A,B](using c: ContextProof[=:=[A,*] *::: End, B]): =:=[A,B] = c.tup.head
diff --git a/core/src/fr/hammons/slinc/types/Arch.scala b/core/src/fr/hammons/slinc/types/Arch.scala
@@ -1,5 +1,9 @@
 package fr.hammons.slinc.types
 
+import scala.annotation.nowarn
+
+//todo: remove once https://github.com/lampepfl/dotty/issues/16878 is fixed
+@nowarn("msg=unused explicit parameter")
 private[slinc] enum Arch:
   case I386
   case X64

diff --git a/core/src/fr/hammons/slinc/types/OS.scala b/core/src/fr/hammons/slinc/types/OS.scala
@@ -1,5 +1,9 @@
 package fr.hammons.slinc.types
 
+import scala.annotation.nowarn
+
+//todo: remove once https://github.com/lampepfl/dotty/issues/16878 is fixed
+@nowarn("msg=unused explicit parameter")
 enum OS:
   case Linux
   case Darwin

diff --git a/core/test/src/fr/hammons/slinc/BindingSpec.scala b/core/test/src/fr/hammons/slinc/BindingSpec.scala
@@ -2,7 +2,10 @@ package fr.hammons.slinc
 
 import munit.ScalaCheckSuite
 import scala.concurrent.duration.*
+import scala.annotation.nowarn
 
+//todo: get rid of this once https://github.com/lampepfl/dotty/issues/16876 is fixed
+@nowarn("msg=unused explicit parameter")
 trait BindingSpec(val slinc: Slinc) extends ScalaCheckSuite:
   import slinc.{given, *}
   override def munitTimeout: Duration = 5.minutes

diff --git a/core/test/src/fr/hammons/slinc/JitManagerSpec.scala b/core/test/src/fr/hammons/slinc/JitManagerSpec.scala
@@ -1,6 +1,5 @@
 package fr.hammons.slinc
 
-import scala.compiletime.uninitialized
 import scala.quoted.staging.Compiler
 import scala.concurrent.Future
 import scala.concurrent.duration.*
@@ -27,7 +26,7 @@ class JitManagerSpec extends munit.FunSuite:
     var code: (() => Int) | Null = null
     import scala.language.unsafeNulls
     jitManager.jitc(() => 1, _('{ () => 2 }), code = _)
-    for i <- 0 until 4
+    for _ <- 0 until 4
     yield code()
 
     Await.result(

diff --git a/core/test/src/fr/hammons/slinc/LibrarySpec.scala b/core/test/src/fr/hammons/slinc/LibrarySpec.scala
diff --git a/core/test/src/fr/hammons/slinc/StdlibSpec.scala b/core/test/src/fr/hammons/slinc/StdlibSpec.scala
@@ -9,6 +9,7 @@ import org.scalacheck.Arbitrary
 import fr.hammons.slinc.types.OS
 import scala.annotation.nowarn
 
+//todo: remove when https://github.com/lampepfl/dotty/issues/16876 is fixed
 @nowarn("msg=unused explicit parameter")
 @nowarn("msg=unused implicit parameter")
 trait StdlibSpec(val slinc: Slinc) extends ScalaCheckSuite: