Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Platform independent file and resource dependencies #134

Merged
merged 1 commit into from
Apr 8, 2023

Conversation

markehammons
Copy link
Collaborator

* Add a mechanism for determining parts of the file names corresponding to a module dependency. Fixes #120
* Add a mechanism for overriding automatic filename determination for module dependencies. #121
@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2023

Codecov Report

Merging #134 (2f54a47) into master (fcfdfc4) will decrease coverage by 0.68%.
The diff coverage is 14.28%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
- Coverage   57.39%   56.71%   -0.68%     
==========================================
  Files          69       69              
  Lines        1779     1802      +23     
  Branches       26       26              
==========================================
+ Hits         1021     1022       +1     
- Misses        758      780      +22     
Flag Coverage Δ
macos-latest 56.38% <14.28%> (-0.62%) ⬇️
ubuntu-latest 56.32% <14.28%> (-0.62%) ⬇️
windows-latest 56.32% <14.28%> (-0.62%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...re/src/fr/hammons/slinc/modules/LinkageTools.scala 34.88% <4.00%> (-13.61%) ⬇️
...e/src/fr/hammons/slinc/annotations/NeedsFile.scala 57.14% <100.00%> (+7.14%) ⬆️
...c/fr/hammons/slinc/annotations/NeedsResource.scala 75.00% <100.00%> (+2.27%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@markehammons markehammons merged commit 130b7d2 into master Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a mechanism for determining parts of the file names corresponding to a module dependency.
2 participants