Move enums to main object #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonas
reviewed
Aug 9, 2018
tests/samples/PrivateMembers.scala
Outdated
| final val D: enum_enumWithPrivateMembers = 1.toUInt | ||
| } | ||
|
|
||
| object anonymous_enum_0 { |
There was a problem hiding this comment.
Any specific reason why anonymous enums do not have the type alias?
There was a problem hiding this comment.
I wonder if it would even make sense to eventually just declare anonymous enum values unnested inside the main Scala object.
There was a problem hiding this comment.
Hmm, I think it will be better to generate type for anonymous enum, it will be more type safe then
kornilova203
force-pushed
the
move-enums-to-main-object
branch
from
34ff98a to
8fdf38f
Compare
|
I added types for anonymous enums, so now there is only one |
kornilova203
force-pushed
the
move-enums-to-main-object
branch
from
8fdf38f to
326f804
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #61
Wrap enumerators in separate objects and place them right below enum type declaration.
Anonymous enums should also be in an object (otherwise code does not compile). I decided to name these objects
anonymous_enum_Nwhere N is id of anonymous enum.I made
Enumclass abstract and created two subclasses:AnonymousEnumcontains id,NamedEnumcontains name.