-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract dependencies from scala-cli via sbt export #2933
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportBase: 90.57% // Head: 90.61% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2933 +/- ##
==========================================
+ Coverage 90.57% 90.61% +0.04%
==========================================
Files 154 155 +1
Lines 3045 3059 +14
Branches 196 208 +12
==========================================
+ Hits 2758 2772 +14
Misses 287 287
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Use the command from https://scala-cli.virtuslab.org/install instead.
Btw, this integration could be nicer and less hacky with a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool idea to use the sbt
export
This implements the idea sketched in #2686 (comment).
ScalaCliAlg
extracts dependencies and resolvers from a Scala CLI "project" via an export to a sbt build and then leveraging the already existingSbtAlg
for the actual data extraction.These two PRs demonstrate that this works:
Note that the base branch of these PRs only contain a single
script.scala
file. There are no other files.