Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try JLine 3.24.1 #856

Closed
SethTisue opened this issue Oct 24, 2023 · 5 comments
Closed

Try JLine 3.24.1 #856

SethTisue opened this issue Oct 24, 2023 · 5 comments
Assignees
Milestone

Comments

@SethTisue
Copy link
Member

probably we could and should upgrade for Scala 2.13.13
https://github.com/jline/jline3/releases/tag/jline-parent-3.23.0

@SethTisue SethTisue added this to the 2.13.13 milestone Oct 24, 2023
@SethTisue SethTisue self-assigned this Oct 24, 2023
@SethTisue SethTisue changed the title Try JLine 3.23.0 Try JLine 3.24.0 Oct 25, 2023
@SethTisue
Copy link
Member Author

@SethTisue
Copy link
Member Author

jline/jline3@a2ab047 "Require JDK 11 and support JDK 21 at build time" is a bit ambiguous — I assume "at build time" is scoped to include "Require JDK 11", but I should double check it does still work at runtime on Java 8

SethTisue added a commit to SethTisue/scala that referenced this issue Oct 28, 2023
@SethTisue SethTisue changed the title Try JLine 3.24.0 Try JLine 3.23.0 Oct 28, 2023
@SethTisue
Copy link
Member Author

SethTisue commented Oct 28, 2023

I should double check it does still work at runtime on Java 8

It doesn't! java.lang.NoSuchMethodError: java.nio.ByteBuffer.limit(I)Ljava/nio/ByteBuffer;

I guess that's why they did 3.23.0 and 3.24.0 in close succession — 3.23.0 to clear the decks before dropping support for 8.

So I guess we'll stick with 3.23.0.

SethTisue added a commit to SethTisue/scala that referenced this issue Oct 28, 2023
@som-snytt
Copy link

This is only a problem because we are not scala-cli. Conversely, REPL could be a multiversion jar for any direct dependencies.

@SethTisue
Copy link
Member Author

The JLine 3 folks now say that 3.24.1 will restore JDK 8 support 👍

@SethTisue SethTisue changed the title Try JLine 3.23.0 Try JLine 3.24.1 Oct 31, 2023
SethTisue added a commit to SethTisue/scala that referenced this issue Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants