Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove legacy bincompat stuff in two places #4640

Merged
merged 1 commit into from
Jul 21, 2015
Merged

remove legacy bincompat stuff in two places #4640

merged 1 commit into from
Jul 21, 2015

Conversation

SethTisue
Copy link
Member

No description provided.

@scala-jenkins scala-jenkins added this to the 2.12.0-M3 milestone Jul 16, 2015
@SethTisue
Copy link
Member Author

review by @lrytz

@SethTisue SethTisue mentioned this pull request Jul 16, 2015
Merged
@lrytz
Copy link
Member

lrytz commented Jul 16, 2015

LGTM. Could have been a single commit for me :)

@SethTisue SethTisue self-assigned this Jul 16, 2015
@SethTisue
Copy link
Member Author

https://scala-ci.typesafe.com/job/scala-2.12.x-validate-test/224/console shows:

java.lang.NoSuchMethodError: scala.collection.immutable.Stream.filter(Lscala/Function1;)Lscala/collection/immutable/Stream;
    at scala.tools.partest.nest.PathSettings$.findJar(PathSettings.scala:31)

This is because the binary incompatible change to Stream broke the partest we're using.

As discussed with @lrytz, the fix steps are:

  1. Patch partest so it works with both M2 and M2+4640. (In this case, maybe use Iterator instead or cast to TraversableLike, something like that.)
  2. Release the patched partest.
  3. In this PR, change version.properties to use the new partest.
  4. (optional) If we don't like the way we had to hack partest, then wait until 2.12.0-M3 (with 4640) is out and make another new partest that depends on it and has the version of the code we like best.

SethTisue added a commit to SethTisue/scala-partest that referenced this pull request Jul 20, 2015
@SethTisue
be compatible with more Scala versions
1ced308 
see scala/scala#4640 for details.
in that PR (targeted for 2.12.0-M3), we are making a binary
incompatible change to Stream. by avoiding using Stream at all here,
we avoid running afoul of the incompatibility.

Stream is arguably overkill here anyway, Iterator is just fine.
so there's no need to change the code back after we're over
the M2/M3 incompatibility hump.
@SethTisue SethTisue mentioned this pull request Jul 20, 2015
Merged
@SethTisue SethTisue force-pushed the remove-old-bincompat branch 2 times, most recently from 8195b96 to b904e15 Compare July 21, 2015 18:26
@SethTisue
remove legacy bincompat stuff in Predef.scala, Stream.scala
1408162 
it was only there to preserve binary compatibility within
the 2.11.x series

includes updated partest, since the old partest ran afoul
of the Stream change
@SethTisue SethTisue force-pushed the remove-old-bincompat branch from b904e15 to 1408162 Compare July 21, 2015 19:06
SethTisue added a commit that referenced this pull request Jul 21, 2015
@SethTisue
Merge pull request #4640 from SethTisue/remove-old-bincompat
f6756ea 
remove legacy bincompat stuff in two places
@SethTisue SethTisue merged commit f6756ea into scala:2.12.x Jul 21, 2015
@SethTisue SethTisue deleted the remove-old-bincompat branch July 21, 2015 22:49
@adriaanm adriaanm added 2.12 and removed 2.12 labels Oct 29, 2016
lrytz pushed a commit to lrytz/scala-partest that referenced this pull request May 9, 2018
@SethTisue
be compatible with more Scala versions
93c5771 
see scala/scala#4640 for details.
in that PR (targeted for 2.12.0-M3), we are making a binary
incompatible change to Stream. by avoiding using Stream at all here,
we avoid running afoul of the incompatibility.

Stream is arguably overkill here anyway, Iterator is just fine.
so there's no need to change the code back after we're over
the M2/M3 incompatibility hump.
lrytz pushed a commit to lrytz/scala-partest that referenced this pull request May 9, 2018
@SethTisue
be compatible with more Scala versions
83bb9db 
see scala/scala#4640 for details.
in that PR (targeted for 2.12.0-M3), we are making a binary
incompatible change to Stream. by avoiding using Stream at all here,
we avoid running afoul of the incompatibility.

Stream is arguably overkill here anyway, Iterator is just fine.
so there's no need to change the code back after we're over
the M2/M3 incompatibility hump.
lrytz pushed a commit to lrytz/scala that referenced this pull request May 9, 2018
@SethTisue @lrytz
be compatible with more Scala versions
29a824c 
see scala#4640 for details.
in that PR (targeted for 2.12.0-M3), we are making a binary
incompatible change to Stream. by avoiding using Stream at all here,
we avoid running afoul of the incompatibility.

Stream is arguably overkill here anyway, Iterator is just fine.
so there's no need to change the code back after we're over
the M2/M3 incompatibility hump.
lrytz pushed a commit to lrytz/scala that referenced this pull request May 9, 2018
@SethTisue @lrytz
be compatible with more Scala versions
314f9ec 
see scala#4640 for details.
in that PR (targeted for 2.12.0-M3), we are making a binary
incompatible change to Stream. by avoiding using Stream at all here,
we avoid running afoul of the incompatibility.

Stream is arguably overkill here anyway, Iterator is just fine.
so there's no need to change the code back after we're over
the M2/M3 incompatibility hump.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SethTisue SethTisue

Labels
None yet
Projects
None yet
Milestone
2.12.0-M3
Development

Successfully merging this pull request may close these issues.
4 participants
@SethTisue @lrytz @adriaanm @scala-jenkins