Nightly Dotty workflow of 2022-01-24 failed

[github-actions]

See https://github.com/lampepfl/dotty/actions/runs/1737834571

[som-snytt]

Duplicates the failures earlier at #13367 which I assumed to be spurious because everything else was green and this passed locally. Though frankly, still difficult to know the canonical way to run a given test. I re-read the contributing page to little avail.

[info] Test dotty.tools.repl.ScriptedTests.replTests started
expected =========>
// scalac: -source:future -deprecation
scala> type M[X] = X match { case Int => String case _ => Int }
1 warning found
-- Deprecation Warning: --------------------------------------------------------
1 | type M[X] = X match { case Int => String case _ => Int }
  |                                               ^
  |        `_` is deprecated for wildcard arguments of types: use `?` instead
scala> type N[X] = X match { case List[_] => Int }
1 warning found
-- Deprecation Warning: --------------------------------------------------------
1 | type N[X] = X match { case List[_] => Int }
  |                                 ^
  |        `_` is deprecated for wildcard arguments of types: use `?` instead
actual ===========>
// scalac: -source:future -deprecation
scala> type M[X] = X match { case Int => String case _ => Int }
scala> type N[X] = X match { case List[_] => Int }
1 warning found
-- Deprecation Warning: --------------------------------------------------------
1 | type N[X] = X match { case List[_] => Int }
  |                                 ^
  |        `_` is deprecated for wildcard arguments of types: use `?` instead
Error:  Test dotty.tools.repl.ScriptedTests.replTests failed: java.lang.AssertionError: Error in script /__w/dotty/dotty/out/bootstrap/scala3-compiler-bootstrapped/scala-3.1.2-RC1-bin-SNAPSHOT-nonbootstrapped/test-classes/repl/i13208.scala, expected output did not match actual, took 8.573 sec
Error:      at dotty.tools.repl.ReplTest.testScript(ReplTest.scala:97)
Error:      at dotty.tools.repl.ReplTest.testFile(ReplTest.scala:42)
Error:      at dotty.tools.repl.ScriptedTests.replTests$$anonfun$1(ScriptedTests.scala:11)
Error:      at scala.runtime.function.JProcedure1.apply(JProcedure1.java:15)
Error:      at scala.runtime.function.JProcedure1.apply(JProcedure1.java:10)
Error:      at scala.collection.ArrayOps$.foreach$extension(ArrayOps.scala:1328)
Error:      at dotty.tools.repl.ScriptedTests.replTests(ScriptedTests.scala:11)
Error:      at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
Error:      at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:78)
Error:      at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
Error:      at java.lang.reflect.Method.invoke(Method.java:567)
Error:      ...

Probably this was meant to be a failed test, where the embedded source string does not compile:

[info] Test dotty.tools.scripting.ExpressionTest.verifyImports started
bashCmd: /bin/bash -c "bin/scala -e 'import java.nio.file.Paths;val cwd = Paths.get(""."");println(cwd.toFile.listFiles.toList.filter(_.isDirectory).size)'"
stdout:
stderr:
-- [E040] Syntax Error: compileFromString-0e84674d-0988-4706-ada1-b683ae96c4d2..scala:2:52 -----------------------------------------------------
2 |  import java.nio.file.Paths;val cwd = Paths.get(""."");println(cwd.toFile.listFiles.toList.filter(_.isDirectory).size)
  |                                                    ^
  |                                                    an identifier expected, but string literal found
Exception in thread "main" dotty.tools.scripting.StringDriverException: Errors encountered during compilation
        at dotty.tools.scripting.StringDriverException$.apply(StringDriver.scala:45)
        at dotty.tools.scripting.StringDriver.compileAndRun(StringDriver.scala:27)
        at dotty.tools.MainGenericRunner$.run$1(MainGenericRunner.scala:256)
        at dotty.tools.MainGenericRunner$.main(MainGenericRunner.scala:266)
        at dotty.tools.MainGenericRunner.main(MainGenericRunner.scala)

[som-snytt]

Maybe the test run of the breaking merge is green because it ran on

succeeded on Nov 18, 2021 

[nicolasstucki]

741e17e is the first commit where there is no warning in

type M[X] = X match { case Int => String case _ => Int }

[nicolasstucki]

741e17e commit was merged in #12261

[som-snytt]

@philwalk see the ExpressionTest output quoted in my comment. There are extra quotes in ""."".

[philwalk]

@philwalk see the ExpressionTest output quoted in my comment. There are extra quotes in ""."".

Sorry for the delay responding, I'll look into it.

[philwalk]

I have a fix for @test dotty.tools.scripting.ExpressionTest#verifyImports
It was missing an assert, so the compile error didn't cause a failed test.
Should this be a new PR? or is there some other way to incorporate the changes to ExpressionTest.scala?

[som-snytt]

@philwalk in the sense that committed PRs are done deals unless reverted, the usual course is just to look to the future and open new PRs. I'm curious to see if the test was supposed to fail, it's a cliff-hanger!