Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect highlight color in REPL #3814

Closed
Atry opened this issue Jan 12, 2018 · 4 comments
Closed

Incorrect highlight color in REPL #3814

Atry opened this issue Jan 12, 2018 · 4 comments

Comments

@Atry
Copy link
Contributor

Atry commented Jan 12, 2018

snapshot

@benkobalog
Copy link
Contributor

I think I found another case: image:

@benkobalog
Copy link
Contributor

benkobalog commented Jan 25, 2018

Can I do this? I have a fix for the first case and for two other cases. (def fn(a:Int) = 1 (Int doesn't get type colour) and print("Hello");def fn = 1 (def stays white))

However for the case in my comment above, I don't have a simple fix yet. One solution would be removing the colour change after "case"-es, so in "case A(a, b, c)" a, b and c would all be just white.

Also I haven't found any tests for highlighting. If there's none is there a plan to add them?

@allanrenucci
Copy link
Contributor

Can I do this?

Sure! 😃

Also I haven't found any tests for highlighting. If there's none is there a plan to add them?

We don't have any. It would be nice to add some, however there is no plan at the moment. It is low priority.

benkobalog added a commit to benkobalog/dotty that referenced this issue Jan 26, 2018
benkobalog added a commit to benkobalog/dotty that referenced this issue Jan 29, 2018
benkobalog added a commit to benkobalog/dotty that referenced this issue Jan 29, 2018
benkobalog added a commit to benkobalog/dotty that referenced this issue Jan 29, 2018
@benkobalog
Copy link
Contributor

I submitted a PR, but currently it only solves the original case and the type coloring after ':' characters.
For the case in my first comment here, it would be easy to remove the cyan coloring, but I don't know how to fix it properly yet. Should I leave the bug in or remove the coloring or try to fix it?

Atry added a commit to Atry/dotty that referenced this issue Jan 29, 2018
benkobalog added a commit to benkobalog/dotty that referenced this issue Jan 29, 2018
Fix scala#3814 Correct highlighting after '&' characters in REPL
benkobalog added a commit to benkobalog/dotty that referenced this issue Jan 29, 2018
Fix scala#3814 Correct highlighting after '&' characters in REPL
benkobalog added a commit to benkobalog/dotty that referenced this issue Jan 29, 2018
Fix scala#3814 Correct highlighting after '&' characters in REPL
benkobalog added a commit to benkobalog/dotty that referenced this issue Jan 29, 2018
benkobalog added a commit to benkobalog/dotty that referenced this issue Jan 29, 2018
benkobalog added a commit to benkobalog/dotty that referenced this issue Feb 12, 2018
Correct highlighting after "|", ":", "&" characters
and after "case", "val", "val" when using extractors.
benkobalog added a commit to benkobalog/dotty that referenced this issue Feb 15, 2018
Correct highlighting after "|", ":", "&" characters
and after "case", "val", "val" when using extractors.
allanrenucci added a commit that referenced this issue May 7, 2018
Fix #3814 Correct highlighting issues in REPL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants