Fix #11061: stop accidentally supported auto-tupling for case classes #10987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liufengyun
force-pushed
the
fix-10958
branch
4 times, most recently
from
a43859c to
a842928
Compare
nicolasstucki
requested review from
nicolasstucki
and removed request for
nicolasstucki
nicolasstucki
suggested changes
Jan 5, 2021
liufengyun
force-pushed
the
fix-10958
branch
3 times, most recently
from
b2933b0 to
360f000
Compare
|
@nicolasstucki: is this one ready to go, given that there is no consensus on #11008? |
|
@nicolasstucki Can we merge this as it fixes #10958 and accidentally supported language features:
Then we can think about how to support the new feature in #11008 . |
We can revert that line of change in this PR and add it as a neg test. The rationale for merging this is that it fixes another important issue #11061: the accidentally supported auto-untupling of case classes.
The code changes of this PR mainly target the bug #11061. |
liufengyun
changed the title
liufengyun
changed the title
nicolasstucki
approved these changes
Jan 16, 2021
|
@liufengyun there is a small conflict with master |
This commit refactor the PR scala#5259 so that it will not impact pattern matching code. scala#5259 - tests/pos/automatic-tupling-of-function-parameters.scala This test requires dealiasing. - tests/run/function-arity.scala This test requires widen ExprType.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11061: stop accidentally supported auto-tupling for case classes
This commit refactor the PR #5259 so that it will not impact pattern
matching code.