dotc settings: String options after settings with colon shouldn't be ignored #1180
Conversation
|
I suspect that expecting a space was a bug in the first place. I would suggest disallowing the variant with the space, but maybe wait for someone else to confirm. |
|
Yes, we should not accept a space here. On Thu, Mar 17, 2016 at 10:47 AM, Sébastien Doeraene <
Martin Odersky |
|
I have added a check for non-empty argument without whitespace for such settings. |
| case (StringTag, _) => | ||
| if (argRest.isEmpty && args.isEmpty) missingArg | ||
| else { | ||
| val (arg, tail) = if (argRest.isEmpty) (args.head, args.tail) else (argRest, args) |
There was a problem hiding this comment.
We should simplify here and not accept a following argument. I suspect then the whole thing will be shorter (which is what we want).
…without whitespace Format of some of the compiler settings was incompatible with scalac. For example "-target:jvm-1.8" is a valid argument for scalac, but it should be "-target: jvm-1.8" (with a whitespace) for dotc.
niktrop
force-pushed
the
dotc-settings-format
branch
from
145c5e2 to
5ff8649
Compare
|
It seems that only ChoiceSettings should behave like Multistring. Other StringSettings don't require colon. I force-pushed simplified version. |
|
LGTM, thanks! |
dotc settings: String options after settings with colon shouldn't be ignored
Format of some of the compiler settings is incompatible with scalac. For example "-target:jvm-1.8" is a valid argument for scalac, but it should be "-target: jvm-1.8" (with a whitespace) for dotc. This commit make both ways to work.