better positioning of _* not last argument error
#1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -234,7 +234,7 @@ object Parsers { | |||
| syntaxErrorOrIncomplete(expectedMsg(token)) | |||
| } | |||
| if (in.token == token) in.nextToken() | |||
| in.offset | |||
| offset | |||
There was a problem hiding this comment.
This change is dubious, but it seems to be what's in the mind of the original author. Otherwise, there's no need to define the variable offset.
There was a problem hiding this comment.
Yes, good catch. It should be offset. Can you add to the doc comment a clause which says "@return The offset at the start of the token to accept"? Thanks!
The error should be at the beginning of the underscore `_`, not the next token after the star `*`, which is the default.
|
I've updated the commit addressing the concerns above. Now the tests pass. |
|
All LGTM now. |
odersky
added a commit
that referenced
this pull request
Mar 22, 2016
better positioning of `_*` not last argument error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error should be at the beginning of the underscore
_,not the next token after the star
*, which is the default.Before:
After: