fix #15222 recursively check for product ctor accessibility #15231
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mostly a refactoring, except now
whyNotGenericSum
will benefit by checking the constructor accessibility of child product types.Removes the
declScope
parameter fromwhyNotGenericSum
because it is not useful. In all cases it is populated by either the companion object ofself
when it is valid to use as the mirror, or it is the context owner when we should use an anonymous mirror. This is awkward because we end up callinguseCompanionAsSumMirror
twice in each recursive call.Also fixes an inconsistency where
scala.Nil.type
would not get a singleton mirror, causing a runtime error (and extends it to aliases of singleton enum values)fixes #15222
fixes #15234