Fix coverage tests on windows #16245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about filenames that contain escaped \, is that possible on Windows? 🤔 |
smarter
approved these changes
Oct 24, 2022
No, because Windows filenames cannot contains backslashes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_windows_full failed
Coverage tests replaced all
\by/, but the paths are now escaped, which turnsC:\folder\fileintoC:\\folder\\file. Thus we need to replace\\by/!Note: this fix is better than removing
.escapedfrom paths, because paths are allowed to contains problematic characters such as newlines, which would break the coverage report.